This is an archive of the discontinued LLVM Phabricator instance.

Fixed function params comparison. Updated docs and tests.
ClosedPublic

Authored by congliu on Jan 26 2016, 9:25 AM.

Details

Summary

"checkParamTypes" may fail if the the type of some parameter is not canonical. Fixed it by comparing canonical types. And added "getCanonicalType()" and "getCanonicalDecl()" on more places to prevent potential fail.

Diff Detail

Repository
rL LLVM

Event Timeline

congliu updated this revision to Diff 46004.Jan 26 2016, 9:25 AM
congliu retitled this revision from to Fixed function params comparison. Updated docs and tests..
congliu updated this object.
congliu added a reviewer: alexfh.
congliu added a subscriber: cfe-commits.
congliu updated this revision to Diff 46359.Jan 28 2016, 11:53 PM
  • Fixed bugs introduced by getCanonicalDecl. Has errs log.
  • Cleared up logs.
  • Added mathcers for static method and overloaded operator.
  • Change key type of map from string to pointer to imporve performance.
  • Change implementation of checkOverrideByDerivedMethod.
congliu updated this revision to Diff 46360.Jan 28 2016, 11:56 PM
  • Fixed a nit in test file.
alexfh accepted this revision.Jan 29 2016, 7:13 AM
alexfh edited edge metadata.

Looks good! I'll commit the patch for you.

This revision is now accepted and ready to land.Jan 29 2016, 7:13 AM
This revision was automatically updated to reflect the committed changes.