This is an archive of the discontinued LLVM Phabricator instance.

Tweak unnamed label syntax in textual IR for easier matching in tests.
ClosedPublic

Authored by eugenis on Jan 25 2016, 3:41 PM.

Details

Reviewers
pcc
Summary

Change the unnamed label comments like

; <label>:8  ; preds = %1

to

; <label>:8:  ; preds = %1

This way lit tests can match [[LABEL]]: in both asserts and no-asserts builds.

Diff Detail

Repository
rL LLVM

Event Timeline

eugenis updated this revision to Diff 45923.Jan 25 2016, 3:41 PM
eugenis retitled this revision from to Tweak unnamed label syntax in textual IR for easier matching in tests..
eugenis updated this object.
eugenis set the repository for this revision to rL LLVM.
eugenis added subscribers: llvm-commits, pcc.
pcc accepted this revision.Jan 25 2016, 3:55 PM
pcc added a reviewer: pcc.

LGTM

We should eventually make it so that numeric labels need to appear explicitly in the textual IR (as a non-comment) rather than being implied by a terminator. But this is definitely an improvement on the status quo.

This revision is now accepted and ready to land.Jan 25 2016, 3:55 PM
eugenis closed this revision.Jan 27 2016, 1:57 PM

Thanks, committed as r258993.