This is an archive of the discontinued LLVM Phabricator instance.

Use std::piecewise_constant_distribution instead of ad-hoc binary search.
ClosedPublic

Authored by krasin on Jan 22 2016, 2:17 PM.

Details

Summary

Fix the issue with the most recently discovered unit receiving much less attention.

Note: this is the second attempt (prev: r258473). Now, libc++ build is fixed.

Diff Detail

Event Timeline

krasin updated this revision to Diff 45742.Jan 22 2016, 2:17 PM
krasin retitled this revision from to Use std::piecewise_constant_distribution instead of ad-hoc binary search..
krasin updated this object.
krasin added reviewers: kcc, aizatsky.
krasin added a subscriber: llvm-commits.
kcc accepted this revision.Jan 22 2016, 2:20 PM
kcc edited edge metadata.

LGTM with nits

lib/Fuzzer/FuzzerInternal.h
204

clang-format, please

287

add a FIXME note saying that ideally we should be able to use GetRand()

This revision is now accepted and ready to land.Jan 22 2016, 2:20 PM
krasin updated this revision to Diff 45746.Jan 22 2016, 2:26 PM
krasin edited edge metadata.

Added a TODO.

krasin updated this revision to Diff 45747.Jan 22 2016, 2:28 PM

clang-format

krasin added inline comments.Jan 22 2016, 2:32 PM
lib/Fuzzer/FuzzerInternal.h
204–205

Done.

287

Done. As discussed offline, the way to go is to expose the generator to the user supplied fuzzer, so that they could seed their internal PRNG, if needed.

krasin closed this revision.Jan 22 2016, 2:32 PM