This is an archive of the discontinued LLVM Phabricator instance.

Differential D16486

Strip local symbols when using externalized debug info.
ClosedPublic

Authored by resistor on Jan 22 2016, 1:55 PM.

Details

Reviewers
beanz
Summary

When we build LLVM with externalized debug info, all debugging and symbolication related data is extracted into dSYM files prior to stripping. As such, there is no need to preserve local symbols in LLVM binaries after dSYM creation.

This shrinks libLLVM.dylib from 58MB to 55MB on my system.

Diff Detail

Repository
rL LLVM

Event Timeline

resistor updated this revision to Diff 45740.Jan 22 2016, 1:55 PM
resistor retitled this revision from to Strip local symbols when using externalized debug info..
resistor updated this object.
resistor added a reviewer: beanz.
resistor set the repository for this revision to rL LLVM.
resistor added a subscriber: llvm-commits.
beanz accepted this revision.Jan 22 2016, 2:06 PM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Jan 22 2016, 2:06 PM
resistor closed this revision.Feb 25 2016, 11:06 AM

Revision Contents

PathSize
cmake/
modules/
2 lines

Diff 45740

cmake/modules/AddLLVM.cmake

Context not available.
endif() endif()
add_custom_command(TARGET ${name} POST_BUILD add_custom_command(TARGET ${name} POST_BUILD
COMMAND xcrun dsymutil $<TARGET_FILE:${name}> COMMAND xcrun dsymutil $<TARGET_FILE:${name}>
COMMAND xcrun strip -Sl $<TARGET_FILE:${name}>) COMMAND xcrun strip -Sxl $<TARGET_FILE:${name}>)
else() else()
message(FATAL_ERROR "LLVM_EXTERNALIZE_DEBUGINFO isn't implemented for non-darwin platforms!") message(FATAL_ERROR "LLVM_EXTERNALIZE_DEBUGINFO isn't implemented for non-darwin platforms!")
endif() endif()
Context not available.