This is an archive of the discontinued LLVM Phabricator instance.

Pass --wrap=pthread_create to linker for -fsplit-stack
ClosedPublic

Authored by hjl.tools on Jan 22 2016, 10:36 AM.

Download Raw Diff

Details

Reviewers

• rafael
rsmith

Summary

From

https://gcc.gnu.org/ml/gcc-patches/2010-09/msg01807.html

-fsplit-stack should pass --wrap=pthread_create to linker for -fsplit-stack
It is needed to initialize the stack guard. This fixes PR 20148.

Diff Detail

Event Timeline

hjl.tools updated this revision to Diff 45698.Jan 22 2016, 10:36 AM

hjl.tools retitled this revision from to Pass --wrap=pthread_create to linker for -fsplit-stack.

hjl.tools updated this object.

hjl.tools added a reviewer: rsmith.

hjl.tools added a subscriber: cfe-commits.

Needs a testcase.

Add a testcase.

LGTM

This revision is now accepted and ready to land.Jan 25 2016, 10:07 AM

Can you check it in for me? Thanks.

258698

Revision Contents

Path

Size

lib/

Driver/

Tools.cpp

3 lines

test/

Driver/

split-stack-ld.c

17 lines

Diff 45735

lib/Driver/Tools.cpp

Context not available.
	if (WantPthread && !isAndroid)	if (WantPthread && !isAndroid)
	CmdArgs.push_back("-lpthread");	CmdArgs.push_back("-lpthread");

		if (Args.hasArg(options::OPT_fsplit_stack))
		CmdArgs.push_back("--wrap=pthread_create");

	CmdArgs.push_back("-lc");	CmdArgs.push_back("-lc");

	if (Args.hasArg(options::OPT_static))	if (Args.hasArg(options::OPT_static))
Context not available.

test/Driver/split-stack-ld.c

This file was added.

				// Test split stack ld flags.
				//
				// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
				// RUN: -target i386-unknown-linux -fsplit-stack \
				// RUN: -resource-dir=%S/Inputs/resource_dir \
				// RUN: --sysroot=%S/Inputs/basic_linux_tree \
				// RUN: \| FileCheck --check-prefix=CHECK-LINUX-I386 %s
				//
				// CHECK-LINUX-I386: "--wrap=pthread_create"
				//
				// RUN: %clang -no-canonical-prefixes %s -### -o %t.o 2>&1 \
				// RUN: -target x86_64-unknown-linux -fsplit-stack \
				// RUN: -resource-dir=%S/Inputs/resource_dir \
				// RUN: --sysroot=%S/Inputs/basic_linux_tree \
				// RUN: \| FileCheck --check-prefix=CHECK-LINUX-X86-64 %s
				//
				// CHECK-LINUX-X86-64: "--wrap=pthread_create"