This is an archive of the discontinued LLVM Phabricator instance.

Call CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab
ClosedPublic

Authored by amccarth on Jan 21 2016, 10:40 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

amccarth updated this revision to Diff 45560.Jan 21 2016, 10:40 AM
amccarth retitled this revision from to Call CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab.
amccarth updated this object.
amccarth added reviewers: tberghammer, zturner.
amccarth added a subscriber: lldb-commits.

looks fine to me, but some Apple targets use PE, so +greg in case he can think of a reason why this will mess up something on the Apple side.

tberghammer edited edge metadata.Jan 21 2016, 11:24 AM

Looks good to me and if Apple using this code then I am pretty sure my CL break them as well. Having 0 size symbols around will cause a lot of issue around LLDB.

clayborg accepted this revision.Jan 21 2016, 12:41 PM
clayborg edited edge metadata.

I just added PECOFF so I could make sure I had 3 clients for the ObjectFile class when I was developing it and I already have the PECOFF support in the previous tool I had written, so this is quite fine to do. I could even fine a PECOFF file that had a symbol table when I made ObjectFilePECOFF so I wasn't able to actually use any of the symbols. We don't use PECOFF at Apple, so this looks good.

This revision is now accepted and ready to land.Jan 21 2016, 12:41 PM
This revision was automatically updated to reflect the committed changes.