This is an archive of the discontinued LLVM Phabricator instance.

Differential D16386

[GlobalISel] make library an optional component
ClosedPublic

Authored by axw on Jan 20 2016, 5:33 PM.

Details

Reviewers
qcolombet
Commits
rGa7a8ab71aa2f: [GlobalISel] make library an optional component
rL258379: [GlobalISel] make library an optional component
Summary

Mark the LLVMGlobalISel library as optional in
LLVMBuild.txt, since the library is only built
if LLVM_BUILD_GLOBAL_ISEL is set. Without doing
this, llvm-config includes the library in the
list of components regardless of whether it's
built, and then will error out when asked for
the library names/paths.

Diff Detail

Event Timeline

axw updated this revision to Diff 45474.Jan 20 2016, 5:33 PM
axw retitled this revision from to [GlobalISel] make library an optional component.
axw updated this object.
axw added a reviewer: qcolombet.
axw added a subscriber: llvm-commits.
Herald added subscribers: vkalintiris, mehdi_amini. · View Herald TranscriptJan 20 2016, 5:33 PM
axw updated this revision to Diff 45475.Jan 20 2016, 5:35 PM

Remove unrelated changes

qcolombet accepted this revision.Jan 20 2016, 5:43 PM
qcolombet edited edge metadata.

LGTM.

Thanks!

We missed it during the first review.

Cheers,
-Quentin

This revision is now accepted and ready to land.Jan 20 2016, 5:43 PM
axw closed this revision.Jan 20 2016, 5:44 PM
ckristo added a subscriber: ckristo.EditedFeb 1 2017, 2:59 PM

I noticed that other OptionalLibrary components (like OProfileJIT) also add the library name to LLVMOPTIONALCOMPONENTS (cf. llvm/CMakeLists.txt:639) -- is this necessary here too?

(I'm not familiar with LLVM's build system and haven't found any documentation about OptionalLibrary; I hope you don't mind that I'm asking here ...)

Revision Contents

PathSize
lib/
CodeGen/
GlobalISel/
2 lines

Diff 45475

lib/CodeGen/GlobalISel/LLVMBuild.txt

Show All 10 Lines
; ;
; For more information on the LLVMBuild system, please see: ; For more information on the LLVMBuild system, please see:
; ;
; http://llvm.org/docs/LLVMBuild.html ; http://llvm.org/docs/LLVMBuild.html
; ;
;===------------------------------------------------------------------------===; ;===------------------------------------------------------------------------===;
[component_0] [component_0]
type = Library type = OptionalLibrary
name = GlobalISel name = GlobalISel
parent = CodeGen parent = CodeGen
required_libraries = Analysis CodeGen Core MC Support Target TransformUtils required_libraries = Analysis CodeGen Core MC Support Target TransformUtils