This is an archive of the discontinued LLVM Phabricator instance.

Fix the error in non-asserts Release mode build. NFC
ClosedPublic

Authored by sgundapa on Jan 19 2016, 8:13 AM.

Diff Detail

Event Timeline

sgundapa updated this revision to Diff 45264.Jan 19 2016, 8:13 AM
sgundapa retitled this revision from to Fix the errors in non-asserts Release mode build. NFC.
sgundapa updated this object.
sgundapa added reviewers: grosser, Meinersbur, zinob.

The patch should be merged only if it is not changing the functionality of the code .

sgundapa added a comment.EditedJan 19 2016, 8:53 AM

This patch indeed causes a lot of crashes in unit tests

sgundapa updated this revision to Diff 45271.Jan 19 2016, 8:58 AM
sgundapa updated this revision to Diff 45301.Jan 19 2016, 1:45 PM
sgundapa retitled this revision from Fix the errors in non-asserts Release mode build. NFC to Fix the error in non-asserts Release mode build. NFC.
grosser edited edge metadata.Jan 19 2016, 3:46 PM

LGTM.

Feel free to commit.

Tobias

Committed revision 258318

sgundapa accepted this revision.Jan 20 2016, 7:48 AM
sgundapa added a reviewer: sgundapa.
This revision is now accepted and ready to land.Jan 20 2016, 7:48 AM
sgundapa closed this revision.Jan 20 2016, 7:48 AM

Committed revision 258318.