This is an archive of the discontinued LLVM Phabricator instance.

[AVX512] Adding VPERMB instruction
ClosedPublic

Authored by m_zuckerman on Jan 18 2016, 6:05 AM.

Diff Detail

Event Timeline

m_zuckerman retitled this revision from to [AVX512] Adding VPERMB instruction .
m_zuckerman updated this object.
m_zuckerman added reviewers: AsafBadouh, igorb, delena.
m_zuckerman added a subscriber: llvm-commits.
delena edited edge metadata.Jan 18 2016, 6:37 AM

Only minor changes, you can fix and commit.

lib/Target/X86/X86InstrAVX512.td
4196

let's call this class avx512_vperm_bw

4210

Please put whitespace after each ','.

lib/Target/X86/X86InstrInfo.td
799

?

m_zuckerman edited edge metadata.
m_zuckerman marked 2 inline comments as done.
AsafBadouh added inline comments.Jan 18 2016, 7:16 AM
lib/Target/X86/X86InstrAVX512.td
4197

you can pass only one predicate:

let Predicates = [prd] in {
            ....
   }
 let Predicates = [prd, HasVLX] in {
          .....
   }
 }
m_zuckerman marked an inline comment as done.
delena accepted this revision.Jan 18 2016, 12:16 PM
delena edited edge metadata.

LGTM, but you added instructions, not intrinsics.

This revision is now accepted and ready to land.Jan 18 2016, 12:16 PM

Yes I know . This is the title of this page: "[AVX512] Adding VPERMB instruction". The intrinsics page(D16296: [AVX512] Adding VPERMB Intrinsics ) depends on this page.

This revision was automatically updated to reflect the committed changes.