Details
Details
Diff Detail
Diff Detail
Event Timeline
lib/Target/Mips/Mips16HardFloat.cpp | ||
---|---|---|
430 | This code seems to be going to some efforts to support the possibility that V is null - does that case need to be handled in the new code? |
lib/Target/Mips/Mips16HardFloat.cpp | ||
---|---|---|
430 | Not as far as I can tell, getFunctionType() seems to be guaranteed non-null. |
Comment Actions
LGTM too. I'll commit it for you.
lib/Target/Mips/Mips16HardFloat.cpp | ||
---|---|---|
430 | CI->getCalledValue() shouldn't return nullptr as well. |
This code seems to be going to some efforts to support the possibility that V is null - does that case need to be handled in the new code?