This is an archive of the discontinued LLVM Phabricator instance.

[NVPTX] Do not emit .hidden or .protected directives as they are not allowed by PTX.
ClosedPublic

Authored by tra on Jan 14 2016, 11:24 AM.

Reviewers

jholewinski
echristo

tra retitled this revision from to [NVPTX] Do not emit .hidden or .protected directives as they are not allowed by PTX. .

tra updated this object.

tra added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Jan 14 2016, 11:28 AM

Committed in r257961

Path

Size

lib/

Target/

NVPTX/

MCTargetDesc/

3 lines

test/

CodeGen/

NVPTX/

16 lines

Show All 35 Lines	NVPTXMCAsmInfo::NVPTXMCAsmInfo(const Triple &TheTriple) {

InlineAsmStart = " inline asm";		InlineAsmStart = " inline asm";
InlineAsmEnd = " inline asm";		InlineAsmEnd = " inline asm";

SupportsDebugInformation = CompileForDebugging;		SupportsDebugInformation = CompileForDebugging;
// PTX does not allow .align on functions.		// PTX does not allow .align on functions.
HasFunctionAlignment = false;		HasFunctionAlignment = false;
HasDotTypeDotSizeDirective = false;		HasDotTypeDotSizeDirective = false;
		// PTX does not allow .hidden or .protected
		HiddenDeclarationVisibilityAttr = HiddenVisibilityAttr = MCSA_Invalid;
		ProtectedVisibilityAttr = MCSA_Invalid;

Data8bitsDirective = " .b8 ";		Data8bitsDirective = " .b8 ";
Data16bitsDirective = " .b16 ";		Data16bitsDirective = " .b16 ";
Data32bitsDirective = " .b32 ";		Data32bitsDirective = " .b32 ";
Data64bitsDirective = " .b64 ";		Data64bitsDirective = " .b64 ";
ZeroDirective = " .b8";		ZeroDirective = " .b8";
AsciiDirective = " .b8";		AsciiDirective = " .b8";
AscizDirective = " .b8";		AscizDirective = " .b8";

// @TODO: Can we just disable this?		// @TODO: Can we just disable this?
WeakDirective = "\t// .weak\t";		WeakDirective = "\t// .weak\t";
GlobalDirective = "\t// .globl\t";		GlobalDirective = "\t// .globl\t";
}		}

				; RUN: llc < %s -march=nvptx -mcpu=sm_20 \| FileCheck %s

				; PTX does not support .hidden or .protected.
				; Make sure we do not emit them.

				define hidden void @f_hidden() {
				ret void
				}
				; CHECK-NOT: .hidden
				; CHECK: .visible .func f_hidden

				define protected void @f_protected() {
				ret void
				}
				; CHECK-NOT: .protected
				; CHECK: .visible .func f_protected