possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext

[ldrumm]

Summary

source/Symbol/ClangASTContext.cpp has using namespace llvm; using namespace clang; Both llvm and clang have an ArrayType class, which can cause resolution to fail when llvm headers that are implicitly included name this type.

[spyffe]

This looks fine. Thanks for paying attention to the details!

lldb/trunk/source/Symbol/ClangASTContext.cpp

if (element_type.IsValid())
         }
         else
         {
         
             llvm::APInt ap_element_count (64, element_count);
             if (element_count == 0)
             {
                 return CompilerType (ast, ast->getIncompleteArrayType (GetQualType(element_type),
-                                                                       ArrayType::Normal,
+                                                                       clang::ArrayType::Normal,
                                                                        0));
             }
             else
             {
                 return CompilerType (ast, ast->getConstantArrayType (GetQualType(element_type),
                                                                      ap_element_count,
-                                                                     ArrayType::Normal,
+                                                                     clang::ArrayType::Normal,
                                                                      0));
             }
         }
     }
     return CompilerType();
 }
 
 CompilerType