Page MenuHomePhabricator

possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext
ClosedPublic

Authored by ldrumm on Jan 13 2016, 2:10 PM.

Details

Summary

source/Symbol/ClangASTContext.cpp has using namespace llvm; using namespace clang; Both llvm and clang have an ArrayType class, which can cause resolution to fail when llvm headers that are implicitly included name this type.

Diff Detail

Repository
rL LLVM

Event Timeline

ldrumm updated this revision to Diff 44788.Jan 13 2016, 2:10 PM
ldrumm retitled this revision from to possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
ldrumm updated this object.
ldrumm added a reviewer: spyffe.
ldrumm retitled this revision from possible ambigous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext to possible ambiguous resolution of clang::ArrayType/llvm::ArrayType in ClangAstContext.
ldrumm added a subscriber: lldb-commits.
spyffe accepted this revision.Jan 13 2016, 2:28 PM
spyffe edited edge metadata.

This looks fine. Thanks for paying attention to the details!

This revision is now accepted and ready to land.Jan 13 2016, 2:28 PM
This revision was automatically updated to reflect the committed changes.