ping

In D99334#2659955, @dblaikie wrote:

what was invalid about the metadata? The llvm.dbg.cu list was empty? I wonder if we should just say that's valid. It seems pretty benign/reasonable - makes it easier to write code like this, or code that, say, stripped a CU out wouldn't have to worry about removing a potentially zero-length cu list. @aprantl @JDevlieghere ?

kito-cheng would you mind looking at the testing here and see whether the correctness testing of NaNs is sufficient?

In D98670#2649998, @kito-cheng wrote:

I just found an issue is unrelated this patch, but related to fp16, RISC-V GCC using the traditional libgcc function name scheme like __extendhfdf2(__<op><srcT><dstT><N_OP>) rather than __gnu_f2h_ieee (__gnu_*2*_ieee).

Function used in GCC:

• __extendhfsf2 for half -> float
• __truncsfhf2 for float -> half
• __extendhfdf2 for double -> half
• __truncdfhf2 for half -> double

In D98957#2643442, @dexonsmith wrote:

Thanks for cleaning this up!

Mostly LGTM, just please split this up into three separate commits (no need for new reviews; any order seems fine, as they seem fully independent):

Good idea. Will do

• Unrelated whitespace changes (BTW, if you just got these incidentally, you can use git-clang-format in the future to just change the lines your commit is touching...).

Seeing as there is now a whitespace only commit, I've just opted to format the whole file as there are plently of other formatting issues picked up in this file

In D98411#2628592, @Anastasia wrote:

In D98411#2626613, @ldrumm wrote:

Given this fixes a runtime crash bug, should it be backported to the relevant release branch?

Sure, thanks!

Given this fixes a runtime crash bug, should it be backported to the relevant release branch?

@Anastasia @svenvh is this already covered by https://reviews.llvm.org/D98039 ?

Ping

Patch updated to not insert trailing blank

I absent mindedly responded to this review via email, without actually checking whether Phabricator supports this. Apologies for the delay

included full diff context

An example of the output:

I found similar unittests for other DWARF entries which allow me to check more about the parser state, so I went with Pavel's suggestion for the testcase

Now emit long-string disabling GCC diagnostic pragmas around string definitions to silence gcc's -Woverlength-strings on a case-by-case basis

• only pass the --long-string-literals flags to *LLVM* tablegen (fixes clang-tablegen problem)
• suppress overlenth-string-literals warning seen in the wild: this behaviour is intended and shouldn't be warned against

In D73044#1836244, @broadwaylamb wrote:

Hello @ldrumm,

Sorry, I had to revert this commit in e464b31c1565204e3be114d043bcbf4de61fe2e9, because it broke some Windows builds:
http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/13870

Remove compile-time detection. Make this a runtime only flag

In D73044#1831436, @mstojanovic wrote:

First char of the title: { -> [.

Thanks. Phabricator doesn't seem to track the git commit message, but I've fixed this is on my tree

Change the cmake flag check to if(MSVC) rather than if(CMAKE_GENERATOR MATCHES "Visual Studio"). CMAKE_GENERATOR is not the compiler

Ensure elaborate cross-compilation setups are supported

switched to the new llvm::Format API

This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a testing failure on greendragon related to ObjC. Unfortunately, I no longer have access to Apple hardware (and at the time the testsuite passed on my local mac), so I'm unable to find out exactly what went wrong.

This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a testing failure on greendragon related to ObjC. Unfortunately, I no longer have access to Apple hardware (and at the time the testsuite passed on my local mac), so I'm unable to find out exactly what went wrong.

updated to use StringRef-based parser rather than char pointers

ping

New candidate is here

Addressed some unwanted whitespace changes as suggested by @bryant; use os.dir.curdir as instead of .

@chandlerc any more thoughts on this?