Page MenuHomePhabricator

Fix project name conflict for MSBuild
ClosedPublic

Authored by jonathanmeier on Jan 13 2016, 12:06 PM.

Details

Summary

CMake allows case sensitive folder naming when setting the folder property of a target. However MSBuild doesn't like that. It complains about having two projects named the same when trying to compile the solution and aborts. (Solution file error MSB5004: The solution file has two projects named "lldb tests")

In lldb/unittests/CMakeLists.txt a folder "LLDB tests" is defined and in lldb/lit/CMakeLists.txt a folder "lldb tests" is defined.

Renaming "lldb tests" to "LLDB tests" in lldb/lit/CMakeLists.txt fixes the problem.

Diff Detail

Repository
rL LLVM

Event Timeline

jonathanmeier retitled this revision from to Fix project name conflict for MSBuild.
jonathanmeier updated this object.
jonathanmeier added a reviewer: zturner.
jonathanmeier added a subscriber: lldb-commits.
zturner accepted this revision.Jan 13 2016, 12:36 PM
zturner edited edge metadata.

looks good, thanks

This revision is now accepted and ready to land.Jan 13 2016, 12:36 PM

Could you please commit that for me? I don't have write access to the repository.

This revision was automatically updated to reflect the committed changes.