This is an archive of the discontinued LLVM Phabricator instance.

Differential D16132

[LLDB][MIPS] Fix TestExprsChar.py
ClosedPublic

Authored by nitesh.jain on Jan 12 2016, 10:00 PM.

Details

Reviewers
ovyalov
clayborg
Summary

When incorrect type used for 'char' then (at least) one of the expression evaluates to incorrect value. Please refer to bug llvm.org/pr23069

Diff Detail

Repository
rL LLVM

Event Timeline

nitesh.jain updated this revision to Diff 44707.Jan 12 2016, 10:00 PM
nitesh.jain retitled this revision from to [LLDB][MIPS] Fix TestExprsChar.py.
nitesh.jain updated this object.
nitesh.jain added reviewers: clayborg, ovyalov.
nitesh.jain set the repository for this revision to rL LLVM.
nitesh.jain added subscribers: jaydeep, bhushan, slthakur and 2 others.
clayborg accepted this revision.Jan 13 2016, 10:19 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Jan 13 2016, 10:19 AM
Diffusion mentioned this in rL258684: [LLDB][MIPS] Fix TestExprsChar.py.Jan 25 2016, 4:31 AM
slthakur closed this revision.Jan 25 2016, 4:32 AM

Committed in revision 258684

hans mentioned this in rL259373: Merging r258684:.Feb 1 2016, 9:29 AM

Revision Contents

PathSize
packages/
Python/
lldbsuite/
test/
expression_command/
char/
1 line

Diff 44707

packages/Python/lldbsuite/test/expression_command/char/TestExprsChar.py

Context not available.
@expectedFailurei386("llvm.org/pr23069") @expectedFailurei386("llvm.org/pr23069")
@expectedFailurex86_64("llvm.org/pr23069") @expectedFailurex86_64("llvm.org/pr23069")
@expectedFailureWindows("llvm.org/pr21765") @expectedFailureWindows("llvm.org/pr21765")
@expectedFailureAll(bugnumber="llvm.org/pr23069", triple = 'mips*')
def test_unsigned_char(self): def test_unsigned_char(self):
self.do_test(dictionary={'CFLAGS_EXTRAS': '-funsigned-char'}) self.do_test(dictionary={'CFLAGS_EXTRAS': '-funsigned-char'})
Context not available.