This is an archive of the discontinued LLVM Phabricator instance.

Differential D16076

Guard fabs to bfc convert with V6T2 flag
ClosedPublic

Authored by apazos on Jan 11 2016, 12:17 PM.

Details

Reviewers
t.p.northover
Commits
rG359cab3bb3b0: Guard fabs to bfc convert with V6T2 flag
rL257546: Guard fabs to bfc convert with V6T2 flag
Summary

BFC instructions are available in ARMv6T2 and above.

Diff Detail

Event Timeline

apazos updated this revision to Diff 44534.Jan 11 2016, 12:17 PM
apazos retitled this revision from to Guard fabs to bfc convert with V6T2 flag.
apazos updated this object.
apazos set the repository for this revision to rL LLVM.
Herald added a subscriber: aemerson. · View Herald TranscriptJan 11 2016, 12:17 PM
apazos added a reviewer: t.p.northover.Jan 11 2016, 12:18 PM
t.p.northover accepted this revision.Jan 12 2016, 12:12 PM
t.p.northover edited edge metadata.

This looks obviously right. Thanks!

Tim.

This revision is now accepted and ready to land.Jan 12 2016, 12:12 PM
apazos closed this revision.Jan 12 2016, 4:07 PM

Revision Contents

PathSize
lib/
Target/
ARM/
4 lines
test/
CodeGen/
ARM/
14 lines

Diff 44534

lib/Target/ARM/ARMInstrVFP.td

Show First 20 Lines • Show All 924 Lines • ▼ Show 20 Linesdef VMOVDRR : AVConv5I<0b11000100, 0b1011,
let isRegSequence = 1; let isRegSequence = 1;
} }
// Hoist an fabs or a fneg of a value coming from integer registers // Hoist an fabs or a fneg of a value coming from integer registers
// and do the fabs/fneg on the integer value. This is never a lose // and do the fabs/fneg on the integer value. This is never a lose
// and could enable the conversion to float to be removed completely. // and could enable the conversion to float to be removed completely.
def : Pat<(fabs (arm_fmdrr GPR:$Rl, GPR:$Rh)), def : Pat<(fabs (arm_fmdrr GPR:$Rl, GPR:$Rh)),
(VMOVDRR GPR:$Rl, (BFC GPR:$Rh, (i32 0x7FFFFFFF)))>, (VMOVDRR GPR:$Rl, (BFC GPR:$Rh, (i32 0x7FFFFFFF)))>,
Requires<[IsARM]>; Requires<[IsARM, HasV6T2]>;
def : Pat<(fabs (arm_fmdrr GPR:$Rl, GPR:$Rh)), def : Pat<(fabs (arm_fmdrr GPR:$Rl, GPR:$Rh)),
(VMOVDRR GPR:$Rl, (t2BFC GPR:$Rh, (i32 0x7FFFFFFF)))>, (VMOVDRR GPR:$Rl, (t2BFC GPR:$Rh, (i32 0x7FFFFFFF)))>,
Requires<[IsThumb2]>; Requires<[IsThumb2, HasV6T2]>;
def : Pat<(fneg (arm_fmdrr GPR:$Rl, GPR:$Rh)), def : Pat<(fneg (arm_fmdrr GPR:$Rl, GPR:$Rh)),
(VMOVDRR GPR:$Rl, (EORri GPR:$Rh, (i32 0x80000000)))>, (VMOVDRR GPR:$Rl, (EORri GPR:$Rh, (i32 0x80000000)))>,
Requires<[IsARM]>; Requires<[IsARM]>;
def : Pat<(fneg (arm_fmdrr GPR:$Rl, GPR:$Rh)), def : Pat<(fneg (arm_fmdrr GPR:$Rl, GPR:$Rh)),
(VMOVDRR GPR:$Rl, (t2EORri GPR:$Rh, (i32 0x80000000)))>, (VMOVDRR GPR:$Rl, (t2EORri GPR:$Rh, (i32 0x80000000)))>,
Requires<[IsThumb2]>; Requires<[IsThumb2]>;
let hasSideEffects = 0 in let hasSideEffects = 0 in
▲ Show 20 Lines • Show All 950 Lines • Show Last 20 Lines

test/CodeGen/ARM/fabs-to-bfc.ll

  • This file was added.
; RUN: llc < %s -mtriple=armv5e-none-linux-gnueabi -mattr=+vfp2 | FileCheck %s -check-prefix=CHECK-VABS
; RUN: llc < %s -mtriple=armv7-none-linux-gnueabi -mattr=+vfp3 | FileCheck %s -check-prefix=CHECK-BFC
define double @test(double %tx) {
;CHECK-LABEL: test:
%call = tail call double @fabs(double %tx)
ret double %call
;CHECK-VABS: vabs.f64
;CHECK-BFC: bfc
}
declare double @fabs(double) readnone