This is an archive of the discontinued LLVM Phabricator instance.

[Verifier] Check parentage of GVs in dbg metadata
ClosedPublic

Authored by loladiro on Jan 11 2016, 5:13 AM.

Details

Summary

Before this the Verifier didn't complain if the GlobalVariable
referenced from a DIGlobalVariable was not in fact in the correct
module (it would crash while writing bitcode though). Fix this by
always checking parantage of GlobalValues while walking constant
expressions and changing the DIGlobalVariable visitor to also
visit the constant it contains.

Diff Detail

Event Timeline

loladiro updated this revision to Diff 44469.Jan 11 2016, 5:13 AM
loladiro retitled this revision from to [Verifier] Check parentage of GVs in dbg metadata.
loladiro updated this object.
loladiro added reviewers: dexonsmith, rafael.
loladiro added a subscriber: llvm-commits.
rafael accepted this revision.Jan 14 2016, 1:23 PM
rafael edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jan 14 2016, 1:23 PM
This revision was automatically updated to reflect the committed changes.