Page MenuHomePhabricator

Centralize the handling of attach permissions on linux in tests
ClosedPublic

Authored by labath on Jan 8 2016, 4:08 AM.

Details

Summary

On linux we need the process to give us special permissions before we can attach to it.
Previously, the code for this was copied into every file that needed it. This moves the code to a
central place to reduce code duplication.

Diff Detail

Repository
rL LLVM

Event Timeline

labath updated this revision to Diff 44316.Jan 8 2016, 4:08 AM
labath retitled this revision from to Centralize the handling of attach permissions on linux in tests.
labath updated this object.
labath added a reviewer: clayborg.
labath added a subscriber: lldb-commits.
clayborg accepted this revision.Jan 8 2016, 9:37 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 9:37 AM

Would you mind adding a note to README-TestSuite saying that you have to call this function if you want to attach to the binary you are building as part of the testsuite. As with all docs it's likely very few will read the note, but we ought to reward the superhumanly diligent...

Good idea. I'll do that.

This revision was automatically updated to reflect the committed changes.