This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Support combining GEP and FrameIndex offsets in memory operand offset field
ClosedPublic

Authored by dschuff on Jan 6 2016, 4:56 PM.

Details

Summary

Previously we only supported putting the FI into memory operand offset
fields if there was nothing there already. Now combine them.

Diff Detail

Event Timeline

dschuff updated this revision to Diff 44181.Jan 6 2016, 4:56 PM
dschuff retitled this revision from to [WebAssembly] Support combining GEP and FrameIndex offsets in memory operand offset field.
dschuff updated this object.
dschuff added reviewers: sunfish, jfb.
dschuff added a subscriber: llvm-commits.
sunfish accepted this revision.Jan 6 2016, 5:11 PM
sunfish edited edge metadata.
sunfish added inline comments.
lib/Target/WebAssembly/WebAssemblyRegisterInfo.cpp
72

It seems like Offset should be an unsigned type, or casted to one, for this comparison, so that we catch negative Offset values too.

This revision is now accepted and ready to land.Jan 6 2016, 5:11 PM
dschuff updated this revision to Diff 44231.Jan 7 2016, 10:58 AM
dschuff marked an inline comment as done.
dschuff edited edge metadata.
  • Cast offset to unsigned type
This revision was automatically updated to reflect the committed changes.