This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/SI: Fix crash when inline assembly is used in a graphics shader
ClosedPublic

Authored by nhaehnle on Jan 5 2016, 1:33 PM.

Details

Summary

This is admittedly something that you could only run into by manually
playing around with shader assembly because the SITypeWriter pass is
skipped for compute.

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle updated this revision to Diff 44051.Jan 5 2016, 1:33 PM
nhaehnle retitled this revision from to AMDGPU/SI: Fix crash when inline assembly is used in a graphics shader.
nhaehnle updated this object.
nhaehnle added reviewers: arsenm, tstellarAMD.
nhaehnle added a subscriber: llvm-commits.
nhaehnle updated this revision to Diff 44052.Jan 5 2016, 1:40 PM

Actually add the correct test.

arsenm accepted this revision.Jan 5 2016, 1:42 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 5 2016, 1:42 PM
This revision was automatically updated to reflect the committed changes.