This is an archive of the discontinued LLVM Phabricator instance.

[MDA] Don't be quite as conservative for noalias functions
ClosedPublic

Authored by reames on Dec 30 2015, 8:41 AM.

Details

Summary

(I just want a second look at this patch for sanity sake.)

If we encounter a noalias call that alias analysis can't analyse, we can fall down into the generic call handling rather than giving up entirely. I noticed this while reading through the code for another purpose.

I can't seem to write a test case which changes; that sorta makes sense given any test case would have to be an inconsistency in AA. Suggestions welcome.

Diff Detail

Event Timeline

reames updated this revision to Diff 43790.Dec 30 2015, 8:41 AM
reames retitled this revision from to [MDA] Don't be quite as conservative for noalias functions.
reames updated this object.
reames added reviewers: dberlin, hfinkel, sanjoy.
reames added a subscriber: llvm-commits.
reames added a comment.Jan 4 2016, 2:20 PM

post holiday ping!

dberlin accepted this revision.Jan 4 2016, 2:29 PM
dberlin edited edge metadata.

Either this is correct, or we have bugs elsewhere, so LGTM.

This revision is now accepted and ready to land.Jan 4 2016, 2:29 PM
This revision was automatically updated to reflect the committed changes.