PR25356 - False positive with -Wreturn-stack-address

[nikola]

Summary

I'd say that test above the one I added also produces a false positive. I was under the impression that r-value won't bind to l-value and is safe to return, am I missing something?

[nikola]

Ping.

lib/Sema/SemaChecking.cpp

     // If we leave the immediate function, the lifetime isn't about to end.
     if (DR->refersToEnclosingVariableOrCapture())
       return nullptr;
 
     if (VarDecl *V = dyn_cast<VarDecl>(DR->getDecl()))
       // If this is a reference variable, follow through to the expression that
       // it points to.
       if (V->hasLocalStorage() &&
-          V->getType()->isReferenceType() && V->hasInit()) {
+          V->getType()->isLValueReferenceType() && V->hasInit()) {
         // Add the reference variable to the "trail".
         refVars.push_back(DR);
         return EvalAddr(V->getInit(), refVars, ParentDecl);
       }
 
     return nullptr;
   }
 

test/SemaCXX/rval-references.cpp

 // RUN: %clang_cc1 -fcxx-exceptions -fexceptions -fsyntax-only -verify -std=c++11 %s
 
 typedef int&& irr;
 typedef irr& ilr_c1; // Collapses to int&
 typedef int& ilr;
 typedef ilr&& ilr_c2; // Collapses to int&
 
 irr ret_irr() {
   return 0; // expected-warning {{returning reference to local temporary}}
 }
 
+namespace PR25356 {
+int* foo();
+
+int* bar() {
+  auto &&x = foo();
+  return x;
+}
+}
+
 struct not_int {};
 
 int over(int&);
 not_int over(int&&);
 
 int over2(const int&);
 not_int over2(int&&);