This creates the initial infrastructure for writing ELF output files. It doesn't yet have any implementation for encoding instructions.
Details
Diff Detail
- Repository
- rL LLVM
Event Timeline
A few minor comments, looks good overall since it'll allow us to try out ELF linking (instead of the hackier bitcode linking).
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
52 | Do like the other architectures, and return WebAssembly::Fixups::NumTargetFixupKinds from WebAssemblyFixupKinds.h? e.g. AMDGPU has fixup_si_rodata. | |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyELFObjectWriter.cpp | ||
37 | Looks like generic-abi@googlegroups.com is the place to contact. Maybe leave it in the FIXME, and we'll email when we have a better idea of what we're going for? | |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp | ||
43 | override | |
45 | New style drops the function prefix in the comment? (here and below) | |
51 | Typo "machine" |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
52 | We don't actually currently have any of our own fixups, as we can currently use the generic ones in MCFixup.h. I changed this to 0 and added a comment. |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
52 | Sounds good, thanks! |
Do like the other architectures, and return WebAssembly::Fixups::NumTargetFixupKinds from WebAssemblyFixupKinds.h? e.g. AMDGPU has fixup_si_rodata.