This creates the initial infrastructure for writing ELF output files. It doesn't yet have any implementation for encoding instructions.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
A few minor comments, looks good overall since it'll allow us to try out ELF linking (instead of the hackier bitcode linking).
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
51 ↗ | (On Diff #42956) | Do like the other architectures, and return WebAssembly::Fixups::NumTargetFixupKinds from WebAssemblyFixupKinds.h? e.g. AMDGPU has fixup_si_rodata. |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyELFObjectWriter.cpp | ||
36 ↗ | (On Diff #42956) | Looks like generic-abi@googlegroups.com is the place to contact. Maybe leave it in the FIXME, and we'll email when we have a better idea of what we're going for? |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCCodeEmitter.cpp | ||
42 ↗ | (On Diff #42956) | override |
44 ↗ | (On Diff #42956) | New style drops the function prefix in the comment? (here and below) |
50 ↗ | (On Diff #42956) | Typo "machine" |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
52 ↗ | (On Diff #43086) | We don't actually currently have any of our own fixups, as we can currently use the generic ones in MCFixup.h. I changed this to 0 and added a comment. |
lib/Target/WebAssembly/MCTargetDesc/WebAssemblyAsmBackend.cpp | ||
---|---|---|
52 ↗ | (On Diff #43086) | Sounds good, thanks! |