This is an archive of the discontinued LLVM Phabricator instance.

[X86] MOVPC32r should only emit CFI adjustments when needed
ClosedPublic

Authored by mkuper on Dec 15 2015, 4:24 AM.

Details

Summary

Trying to emit CFI adjustments for MOVPC32r caused failures under windows.
Since we're so late in the pipeline here, I think the right thing to do is not to "guess" whether we should be emitting DWARF or not, but just check directly.

This fixes PR25828.

Diff Detail

Repository
rL LLVM

Event Timeline

mkuper updated this revision to Diff 42834.Dec 15 2015, 4:24 AM
mkuper retitled this revision from to [X86] MOVPC32r should only emit CFI adjustments when needed.
mkuper updated this object.
mkuper added reviewers: majnemer, rnk, violetav.
mkuper added a subscriber: llvm-commits.
rnk accepted this revision.Dec 15 2015, 9:40 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Dec 15 2015, 9:40 AM
This revision was automatically updated to reflect the committed changes.