This is an archive of the discontinued LLVM Phabricator instance.

Polybench: Remove undefined behavior introduce in r241675
ClosedPublic

Authored by grosser on Dec 10 2015, 6:35 AM.

Details

Summary
  • Make sure strings are NULL terminated
  • The floats we look at are double, not single precision. Hence, do not forget to hash the second part.

Diff Detail

Repository
rL LLVM

Event Timeline

grosser updated this revision to Diff 42423.Dec 10 2015, 6:35 AM
grosser retitled this revision from to Polybench: Remove undefined behavior introduce in r241675.
grosser updated this object.
grosser added a reviewer: rengolin.
grosser added a subscriber: llvm-commits.

Hi Renato,

you are probably off for holidays, but I still want to "ping" this patch to at least ensure it's at the beginning of the mailbox when you get back. ;) I would very much appreciate a review then.

Thank you and happy holidays!
Tobias

Hi Hal (or Renato),

I am waiting since a while on a review for this patch. Could you guys possibly have a look.

All the best,
Tobias

rengolin accepted this revision.Jan 14 2016, 1:38 AM
rengolin edited edge metadata.

Hi Tobi,

Sorry for the delay, I missed this completely!

The change makes total sense. LGTM!

cheers,
--renato

This revision is now accepted and ready to land.Jan 14 2016, 1:38 AM
This revision was automatically updated to reflect the committed changes.