This is an archive of the discontinued LLVM Phabricator instance.

Differential D15403

[InstCombine] Adding "\n" to debug output. NFC.
ClosedPublic

Authored by zzheng on Dec 9 2015, 5:55 PM.

Details

Reviewers
majnemer
weimingz
apazos
Commits
rG24fbef55f9d4: [InstCombine] Adding "\n" to debug output. NFC.
rL255920: [InstCombine] Adding "\n" to debug output. NFC.
Summary

[InstCombine] Adding '\n' to debug output. NFC.

Patch by Zhaoshi Zheng <zhaoshiz@codeaurora.org>

Diff Detail

Repository
rL LLVM

Event Timeline

zzheng updated this revision to Diff 42368.Dec 9 2015, 5:55 PM
zzheng retitled this revision from to [InstCombine] Adding "\n" to debug output. NFC..
zzheng updated this object.
zzheng added a reviewer: apazos.
zzheng set the repository for this revision to rL LLVM.
zzheng added a subscriber: llvm-commits.
arsenm added a subscriber: arsenm.Dec 9 2015, 5:56 PM
arsenm added inline comments.
lib/Transforms/InstCombine/InstCombineCasts.cpp
1104

Single character should use single quotes

zzheng added a reviewer: majnemer.Dec 9 2015, 5:58 PM
zzheng updated this revision to Diff 42447.Dec 10 2015, 10:50 AM
zzheng marked an inline comment as done.

Using single quotation marks for '\n' in patch set 2.

majnemer accepted this revision.Dec 10 2015, 1:42 PM
majnemer edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 10 2015, 1:42 PM
zzheng updated this object.Dec 17 2015, 11:47 AM
zzheng edited edge metadata.
zzheng updated this revision to Diff 43166.Dec 17 2015, 11:54 AM
zzheng updated this object.
zzheng added a reviewer: weimingz.

Rebased.

weimingz closed this revision.Dec 17 2015, 11:56 AM

Revision Contents

PathSize
lib/
Transforms/
InstCombine/
4 lines

Diff 43166

lib/Transforms/InstCombine/InstCombineCasts.cpp

Context not available.
// Okay, we can transform this! Insert the new expression now. // Okay, we can transform this! Insert the new expression now.
DEBUG(dbgs() << "ICE: EvaluateInDifferentType converting expression type" DEBUG(dbgs() << "ICE: EvaluateInDifferentType converting expression type"
" to avoid zero extend: " << CI); " to avoid zero extend: " << CI << '\n');
Value *Res = EvaluateInDifferentType(Src, DestTy, false); Value *Res = EvaluateInDifferentType(Src, DestTy, false);
assert(Res->getType() == DestTy); assert(Res->getType() == DestTy);
arsenmUnsubmitted
Done
ReplyInline Actions

Single character should use single quotes

arsenm: Single character should use single quotes
Context not available.
canEvaluateSExtd(Src, DestTy)) { canEvaluateSExtd(Src, DestTy)) {
// Okay, we can transform this! Insert the new expression now. // Okay, we can transform this! Insert the new expression now.
DEBUG(dbgs() << "ICE: EvaluateInDifferentType converting expression type" DEBUG(dbgs() << "ICE: EvaluateInDifferentType converting expression type"
" to avoid sign extend: " << CI); " to avoid sign extend: " << CI << '\n');
Value *Res = EvaluateInDifferentType(Src, DestTy, true); Value *Res = EvaluateInDifferentType(Src, DestTy, true);
assert(Res->getType() == DestTy); assert(Res->getType() == DestTy);
Context not available.