This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] Add some cross-compile options.
ClosedPublic

Authored by mcrosier on Dec 3 2015, 2:12 PM.

Details

Reviewers
MatzeB
rnk
Summary

The value of variable TEST_SUITE_EXE_WRAPPER, if present, is passed to
RunSafely.sh 's -u parameter, to wrap the test execution within. This is
mainly intended to be used while cross-compiling to run under an
emulator.

(I'm submitting this on behalf of a fellow engineer, so please be kind to the messenger :)

Chad

Diff Detail

Event Timeline

mcrosier updated this revision to Diff 41801.Dec 3 2015, 2:12 PM
mcrosier retitled this revision from to [test-suite] Add some cross-compile options..
mcrosier updated this object.
mcrosier added reviewers: MatzeB, rnk.
mcrosier added a subscriber: llvm-commits.
MatzeB edited edge metadata.Dec 3 2015, 2:17 PM

The timeit/fpcmp thing seems to have the same goal as http://reviews.llvm.org/D15004 and should probably be discussed separately.

Passing -u along makes sense, though I'd prefer to call it TEST_SUITE_RUN_UNDER simply because the concept is already called RUN_UNDER in RunSafely and the makefiles and I'd like to avoid introducing a 2nd name for the concept.

mcrosier updated this revision to Diff 41875.Dec 4 2015, 7:15 AM
mcrosier updated this object.
mcrosier edited edge metadata.

Address Matthias' comments. Specifically,
-Drop the timeit/fpcmp stuff in favor of http://reviews.llvm.org/D15004.
-Use the preferred name TEST_SUITE_RUN_UNDER.

MatzeB accepted this revision.Dec 4 2015, 10:14 AM
MatzeB edited edge metadata.

LGTM

This revision is now accepted and ready to land.Dec 4 2015, 10:14 AM
mcrosier closed this revision.Dec 4 2015, 12:40 PM

Committed in r254765.