This is an archive of the discontinued LLVM Phabricator instance.

Add support for "xlat m8"
ClosedPublic

Authored by myatsina on Dec 2 2015, 5:53 AM.

Details

Summary

According to x86 spec "xlat m8" is a legal instruction and it is equivalent to "xlatb".

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 41618.Dec 2 2015, 5:53 AM
myatsina retitled this revision from to Add support for "xlat m8".
myatsina updated this object.
myatsina added a reviewer: rnk.
myatsina set the repository for this revision to rL LLVM.
myatsina added a subscriber: llvm-commits.
rnk edited edge metadata.Dec 2 2015, 11:30 AM

This is another instruction that gas warns on when you don't pass the expected [ebx] operand.

myatsina updated this revision to Diff 42667.Dec 13 2015, 9:00 AM
myatsina edited edge metadata.

Added warning regarding the fact that these instructions use (R|E)BX instead of the specified memory operand

I've added the warning as you suggested, can you please review the new version?

rnk accepted this revision.Jan 13 2016, 11:21 AM
rnk edited edge metadata.

lgtm

Thanks, just got back from vacation.

This revision is now accepted and ready to land.Jan 13 2016, 11:21 AM
This revision was automatically updated to reflect the committed changes.