This is an archive of the discontinued LLVM Phabricator instance.

Differential D15148

Add support for loopz, loopnz for Intel syntax
ClosedPublic

Authored by myatsina on Dec 2 2015, 5:37 AM.

Details

Reviewers
rnk
mcrosier
Commits
rG1d1aa0b0a859: [X86] Add support for loopz, loopnz for Intel syntax
rL254877: [X86] Add support for loopz, loopnz for Intel syntax
Summary

According to x86 spec, loopz and loopnz should be supported for Intel syntax, where loopz is equivalent to loope and loopnz is equivalent to loopne

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 41615.Dec 2 2015, 5:37 AM
myatsina retitled this revision from to Add support for loopz, loopnz for Intel syntax.
myatsina updated this object.
myatsina added reviewers: rnk, mcrosier.
myatsina set the repository for this revision to rL LLVM.
myatsina added a subscriber: llvm-commits.
mcrosier accepted this revision.Dec 2 2015, 5:47 AM
mcrosier edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 2 2015, 5:47 AM
jevinskie added a subscriber: jevinskie.Dec 2 2015, 11:29 AM
Closed by commit rL254877: [X86] Add support for loopz, loopnz for Intel syntax (authored by myatsina). · Explain WhyDec 6 2015, 7:34 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
X86/
4 lines
test/
MC/
X86/
5 lines

Diff 42012

llvm/trunk/lib/Target/X86/X86InstrInfo.td

Show First 20 Lines • Show All 2,566 Lines • ▼ Show 20 Lines
// In 64-bit mode lret maps to lretl; it is not ambiguous with lretq. // In 64-bit mode lret maps to lretl; it is not ambiguous with lretq.
def : MnemonicAlias<"lret", "lretw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"lret", "lretw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"lret", "lretl", "att">, Requires<[Not16BitMode]>; def : MnemonicAlias<"lret", "lretl", "att">, Requires<[Not16BitMode]>;
def : MnemonicAlias<"leavel", "leave", "att">, Requires<[Not64BitMode]>; def : MnemonicAlias<"leavel", "leave", "att">, Requires<[Not64BitMode]>;
def : MnemonicAlias<"leaveq", "leave", "att">, Requires<[In64BitMode]>; def : MnemonicAlias<"leaveq", "leave", "att">, Requires<[In64BitMode]>;
def : MnemonicAlias<"loopz", "loope", "att">; def : MnemonicAlias<"loopz", "loope">;
def : MnemonicAlias<"loopnz", "loopne", "att">; def : MnemonicAlias<"loopnz", "loopne">;
def : MnemonicAlias<"pop", "popw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"pop", "popw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"pop", "popl", "att">, Requires<[In32BitMode]>; def : MnemonicAlias<"pop", "popl", "att">, Requires<[In32BitMode]>;
def : MnemonicAlias<"pop", "popq", "att">, Requires<[In64BitMode]>; def : MnemonicAlias<"pop", "popq", "att">, Requires<[In64BitMode]>;
def : MnemonicAlias<"popf", "popfw", "att">, Requires<[In16BitMode]>; def : MnemonicAlias<"popf", "popfw", "att">, Requires<[In16BitMode]>;
def : MnemonicAlias<"popf", "popfl", "att">, Requires<[In32BitMode]>; def : MnemonicAlias<"popf", "popfl", "att">, Requires<[In32BitMode]>;
def : MnemonicAlias<"popf", "popfq", "att">, Requires<[In64BitMode]>; def : MnemonicAlias<"popf", "popfq", "att">, Requires<[In64BitMode]>;
def : MnemonicAlias<"popfd", "popfl", "att">; def : MnemonicAlias<"popfd", "popfl", "att">;
▲ Show 20 Lines • Show All 468 Lines • Show Last 20 Lines

llvm/trunk/test/MC/X86/intel-syntax.s

Show First 20 Lines • Show All 735 Lines • ▼ Show 20 Lines
fbstp tbyte ptr [eax] fbstp tbyte ptr [eax]
// CHECK: fbld (%eax) // CHECK: fbld (%eax)
// CHECK: fbstp (%eax) // CHECK: fbstp (%eax)
fcomip st, st(2) fcomip st, st(2)
fucomip st, st(2) fucomip st, st(2)
// CHECK: fcompi %st(2) // CHECK: fcompi %st(2)
// CHECK: fucompi %st(2) // CHECK: fucompi %st(2)
loopz _foo
loopnz _foo
// CHECK: loope _foo
// CHECK: loopne _foo