This is an archive of the discontinued LLVM Phabricator instance.

Differential D14977

clang-tidy: code cleanup with isAssignmentOperator
ClosedPublic

Authored by danielmarjamaki on Nov 25 2015, 2:21 AM.

Details

Reviewers
alexfh
Summary

This is a small code cleanup. No change in logical behaviour is intended.

Diff Detail

Event Timeline

danielmarjamaki updated this revision to Diff 41117.Nov 25 2015, 2:21 AM
danielmarjamaki retitled this revision from to clang-tidy: code cleanup with isAssignmentOperator.
danielmarjamaki updated this object.
danielmarjamaki added subscribers: cfe-commits, alexfh.
alexfh accepted this revision.Nov 25 2015, 2:44 AM
alexfh added a reviewer: alexfh.

LGTM

This revision is now accepted and ready to land.Nov 25 2015, 2:44 AM
danielmarjamaki closed this revision.Nov 25 2015, 3:33 AM

Committed with 254066.

Revision Contents

PathSize
clang-tidy/
misc/
6 lines

Diff 41117

clang-tidy/misc/AssertSideEffectCheck.cpp

Show All 27 LinesAST_MATCHER_P(Expr, hasSideEffect, bool, CheckFunctionCalls) {
if (const auto *Op = dyn_cast<UnaryOperator>(E)) { if (const auto *Op = dyn_cast<UnaryOperator>(E)) {
UnaryOperator::Opcode OC = Op->getOpcode(); UnaryOperator::Opcode OC = Op->getOpcode();
return OC == UO_PostInc || OC == UO_PostDec || OC == UO_PreInc || return OC == UO_PostInc || OC == UO_PostDec || OC == UO_PreInc ||
OC == UO_PreDec; OC == UO_PreDec;
} }
if (const auto *Op = dyn_cast<BinaryOperator>(E)) { if (const auto *Op = dyn_cast<BinaryOperator>(E)) {
BinaryOperator::Opcode OC = Op->getOpcode(); return Op->isAssignmentOp();
return OC == BO_Assign || OC == BO_MulAssign || OC == BO_DivAssign ||
OC == BO_RemAssign || OC == BO_AddAssign || OC == BO_SubAssign ||
OC == BO_ShlAssign || OC == BO_ShrAssign || OC == BO_AndAssign ||
OC == BO_XorAssign || OC == BO_OrAssign;
} }
if (const auto *OpCallExpr = dyn_cast<CXXOperatorCallExpr>(E)) { if (const auto *OpCallExpr = dyn_cast<CXXOperatorCallExpr>(E)) {
OverloadedOperatorKind OpKind = OpCallExpr->getOperator(); OverloadedOperatorKind OpKind = OpCallExpr->getOperator();
return OpKind == OO_Equal || OpKind == OO_PlusEqual || return OpKind == OO_Equal || OpKind == OO_PlusEqual ||
OpKind == OO_MinusEqual || OpKind == OO_StarEqual || OpKind == OO_MinusEqual || OpKind == OO_StarEqual ||
OpKind == OO_SlashEqual || OpKind == OO_AmpEqual || OpKind == OO_SlashEqual || OpKind == OO_AmpEqual ||
OpKind == OO_PipeEqual || OpKind == OO_CaretEqual || OpKind == OO_PipeEqual || OpKind == OO_CaretEqual ||
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines