This is an archive of the discontinued LLVM Phabricator instance.

Fix bug where WinCOFFObjectWriter would assume starting from an empty output.
ClosedPublic

Authored by klimek on Nov 18 2015, 7:18 AM.

Details

Reviewers
bkramer
Summary

Starting on an input stream that is not at offset 0 would trigger the
assert in WinCOFFObjectWriter.cpp:1065:

assert(getStream().tell() <= (*i)->Header.PointerToRawData &&
               "Section::PointerToRawData is insane!");

Diff Detail

Event Timeline

klimek updated this revision to Diff 40507.Nov 18 2015, 7:18 AM
klimek retitled this revision from to Fix bug where WinCOFFObjectWriter would assume starting from an empty output..
klimek updated this object.
klimek added a reviewer: bkramer.
klimek added a subscriber: llvm-commits.
bkramer accepted this revision.Nov 18 2015, 7:24 AM
bkramer edited edge metadata.

Looks good. Nice test case :)

This revision is now accepted and ready to land.Nov 18 2015, 7:24 AM
klimek closed this revision.Nov 18 2015, 7:27 AM

Thx. Submitted as r253464.