This is an archive of the discontinued LLVM Phabricator instance.

Differential D147680

[ASan][libc++] Turn on ASan annotations for short strings
AbandonedPublic

Authored by AdvenamTacet on Apr 5 2023, 10:39 PM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Summary

This patch turns on ASan annotations for short strings.

Revision D132769 adds ASan annotations for strings, but annotations for short strings are turned off.
An implementation from there is correct for both string types and support for the later may be easily turned on.
This revision does it.

Reasoning behind moving it here, to a different revision:

  • Long string annotations (with the default allocator only) work with old ASan API.
  • Short string annotations requires new ASan API (added in rGdd1b7b797a116eed588fd752fbe61d34deeb24e4).
  • If someone reports a problem with string annotations, it makes it much easier to know which patch exactly caused the problem.
  • Long string is almost same as std::vector, so chance for a problem with D132769 is minimal.

Diff Detail

Unit TestsFailed

TimeTest
3,520 mslibcxx CI GCC 12 / C++latest > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
3,520 mslibcxx CI GCC 12 / C++latest > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
3,520 mslibcxx CI GCC 12 / C++latest > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
3,520 mslibcxx CI GCC 12 / C++latest > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
3,520 mslibcxx CI GCC 12 / C++latest > llvm-libc++-shared-gcc-cfg-in.libcxx::double_include.sh.cpp
View Full Test Results (16,330 Failed)

Event Timeline

AdvenamTacet created this revision.Apr 5 2023, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 10:39 PM
AdvenamTacet requested review of this revision.Apr 5 2023, 10:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 5 2023, 10:39 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
Harbormaster completed remote builds in B223921: Diff 511279.Apr 5 2023, 10:39 PM
AdvenamTacet added a parent revision: D132769: [2b/3][ASan][libcxx] std::basic_string annotations.Apr 5 2023, 10:42 PM
AdvenamTacet mentioned this in D132769: [2b/3][ASan][libcxx] std::basic_string annotations.Apr 5 2023, 11:05 PM
EricWF added a subscriber: EricWF.Apr 11 2023, 11:23 AM

Can you please update the patch so that it merges?

AdvenamTacet updated this revision to Diff 514108.Apr 16 2023, 11:29 PM

This update tries to fix the conflict problem.

Harbormaster completed remote builds in B226013: Diff 514108.Apr 17 2023, 12:11 AM
GitHub <noreply@github.com> mentioned this in rG9ed20568e7de: [ASan][libc++] std::basic_string annotations (#72677).Dec 12 2023, 9:05 PM
AdvenamTacet abandoned this revision.Dec 18 2023, 5:37 PM

Moved to GH: https://github.com/llvm/llvm-project/pull/75882

GitHub <noreply@github.com> mentioned this in rGd06fb0b29c70: [ASan][libc++] Turn on ASan annotations for short strings (#75882).Wed, Jan 17, 8:55 PM

Revision Contents

PathSize
libcxx/
include/
7 lines

Diff 514108

libcxx/include/string

Show First 20 Lines • Show All 611 Lines • ▼ Show 20 Lines
# define _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS __attribute__((__no_sanitize__("address"))) # define _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS __attribute__((__no_sanitize__("address")))
// Sometimes string access own memory, which should not be accessed by different parts of program // Sometimes string access own memory, which should not be accessed by different parts of program
// (eg. not-in-use bytes of buffer in short string) and are poisoned by ASan. // (eg. not-in-use bytes of buffer in short string) and are poisoned by ASan.
// This macro turns off instrumentation in a function, so memory accesses which normally would crash // This macro turns off instrumentation in a function, so memory accesses which normally would crash
// work as expected. // work as expected.
#else #else
# define _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS # define _LIBCPP_STRING_INTERNAL_MEMORY_ACCESS
#endif #endif
#if (_LIBCPP_CLANG_VER >= 1600)
// TODO LLVM18: Remove special casing or macro
# define _LIBCPP_SHORT_STRING_ANNOTATIONS_ALLOWED true
#else
#define _LIBCPP_SHORT_STRING_ANNOTATIONS_ALLOWED false # define _LIBCPP_SHORT_STRING_ANNOTATIONS_ALLOWED false
#endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
// basic_string // basic_string
template<class _CharT, class _Traits, class _Allocator> template<class _CharT, class _Traits, class _Allocator>
basic_string<_CharT, _Traits, _Allocator> basic_string<_CharT, _Traits, _Allocator>
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20
▲ Show 20 Lines • Show All 3,955 Lines • Show Last 20 Lines