This is an archive of the discontinued LLVM Phabricator instance.

Support unix-abstract-connect scheme as platform url in lldb testsuite
ClosedPublic

Authored by chying on Nov 17 2015, 5:30 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

chying updated this revision to Diff 40463.Nov 17 2015, 5:30 PM
chying retitled this revision from to Support unix-abstract-connect scheme as platform url in lldb testsuite.
chying updated this object.
chying added a reviewer: ovyalov.
chying added a subscriber: lldb-commits.
ovyalov edited edge metadata.Nov 17 2015, 5:44 PM

Please see my comments.

packages/Python/lldbsuite/test/lldbtest.py
464 ↗(On Diff #40463)

I think in case of Android we can always treat result of parsed_url.netloc.split(":")[0] as a device id unless it's set to 'localhost' - it should hold true for any protocol scheme.

packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
64 ↗(On Diff #40463)

You may use "unix-" to allow regular domain sockets as well.

69 ↗(On Diff #40463)

if host != 'localhost' ?

chying updated this revision to Diff 40469.Nov 17 2015, 7:32 PM
chying edited edge metadata.

Address comments.

chying marked 2 inline comments as done.Nov 17 2015, 7:34 PM
chying added inline comments.
packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
69 ↗(On Diff #40469)

As discussed offline, add check for remote platform is android as well.

ovyalov accepted this revision.Nov 18 2015, 10:28 AM
ovyalov edited edge metadata.

LGTM

packages/Python/lldbsuite/test/lldbtest.py
464 ↗(On Diff #40469)

Nit - you may save parsed_url.netloc.split(":")[0] as local variable like host_name

This revision is now accepted and ready to land.Nov 18 2015, 10:28 AM
chying marked an inline comment as done.Nov 18 2015, 11:05 AM
This revision was automatically updated to reflect the committed changes.