Support unix-abstract-connect scheme as platform url in lldb testsuite

[ovyalov]

Please see my comments.

packages/Python/lldbsuite/test/lldbtest.py

464 ↗

(On Diff #40463)

I think in case of Android we can always treat result of parsed_url.netloc.split(":")[0] as a device id unless it's set to 'localhost' - it should hold true for any protocol scheme.

packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

64 ↗

(On Diff #40463)

You may use "unix-" to allow regular domain sockets as well.

69 ↗

(On Diff #40463)

if host != 'localhost' ?

[chying]

Address comments.

[chying]

packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

69 ↗

(On Diff #40469)

As discussed offline, add check for remote platform is android as well.

[ovyalov]

LGTM

packages/Python/lldbsuite/test/lldbtest.py

464 ↗

(On Diff #40469)

Nit - you may save parsed_url.netloc.split(":")[0] as local variable like host_name

lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py

if not hasattr(target_is_android, 'result'):
         target_is_android.result = match is not None
     return target_is_android.result
 
 def android_device_api():
     if not hasattr(android_device_api, 'result'):
         assert lldb.platform_url is not None
         device_id = None
         parsed_url = urlparse.urlparse(lldb.platform_url)
-        if parsed_url.scheme == "adb":
-            device_id = parsed_url.netloc.split(":")[0]
+        host_name = parsed_url.netloc.split(":")[0]
+        if host_name != 'localhost':
+            device_id = host_name
+            if device_id.startswith('[') and device_id.endswith(']'):
+                device_id = device_id[1:-1]
         retcode, stdout, stderr = run_adb_command(
             ["shell", "getprop", "ro.build.version.sdk"], device_id)
         if retcode == 0:
             android_device_api.result = int(stdout)
         else:
             raise LookupError(
                 ">>> Unable to determine the API level of the Android device.\n"
                 ">>> stdout:\n%s\n"

lldb/trunk/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

def setUp(self):
         self.test_sequence = GdbRemoteTestSequence(self.logger)
         self.set_inferior_startup_launch()
         self.port = self.get_next_port()
         self.named_pipe_path = None
         self.named_pipe = None
         self.named_pipe_fd = None
         self.stub_sends_two_stop_notifications_on_kill = False
         if lldb.platform_url:
-            scheme, host = re.match('(.+)://(.+):\d+', lldb.platform_url).groups()
-            if scheme == 'adb':
+            if lldb.platform_url.startswith('unix-'):
+                url_pattern = '(.+)://\[?(.+?)\]?/.*'
+            else:
+                url_pattern = '(.+)://(.+):\d+'
+            scheme, host = re.match(url_pattern, lldb.platform_url).groups()
+            if lldb.remote_platform_name == 'remote-android' and host != 'localhost':
                 self.stub_device = host
                 self.stub_hostname = 'localhost'
             else:
                 self.stub_device = None
                 self.stub_hostname = host
         else:
             self.stub_hostname = "localhost"