This is an archive of the discontinued LLVM Phabricator instance.

Differential D14671

AMDGPU: Use the default strings for data emission directives
ClosedPublic

Authored by • tstellarAMD on Nov 13 2015, 5:51 PM.

Details

Reviewers
arsenm
Commits
rGff63c25753a5: AMDGPU: Use the default strings for data emission directives
rL254426: AMDGPU: Use the default strings for data emission directives
Summary

This makes the assembly output look nicer and there is no reason to
have custom strings for these.

Diff Detail

Repository
rL LLVM

Event Timeline

• tstellarAMD updated this revision to Diff 40192.Nov 13 2015, 5:51 PM
• tstellarAMD retitled this revision from to AMDGPU: Use the default strings for data emission directives.
• tstellarAMD updated this object.
• tstellarAMD added a reviewer: arsenm.
• tstellarAMD added a subscriber: llvm-commits.
Herald added a subscriber: arsenm. · View Herald TranscriptNov 13 2015, 5:51 PM
arsenm accepted this revision.Nov 30 2015, 1:21 PM
arsenm edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 30 2015, 1:21 PM
Closed by commit rL254426: AMDGPU: Use the default strings for data emission directives (authored by tstellar). · Explain WhyDec 1 2015, 9:48 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Target/
AMDGPU/
MCTargetDesc/
7 lines

Diff 41529

llvm/trunk/lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.cpp

Show All 16 LinesAMDGPUMCAsmInfo::AMDGPUMCAsmInfo(const Triple &TT) : MCAsmInfoELF() {
MaxInstLength = 16; MaxInstLength = 16;
SeparatorString = "\n"; SeparatorString = "\n";
CommentString = ";"; CommentString = ";";
PrivateLabelPrefix = ""; PrivateLabelPrefix = "";
InlineAsmStart = ";#ASMSTART"; InlineAsmStart = ";#ASMSTART";
InlineAsmEnd = ";#ASMEND"; InlineAsmEnd = ";#ASMEND";
//===--- Data Emission Directives -------------------------------------===// //===--- Data Emission Directives -------------------------------------===//
ZeroDirective = ".zero";
AsciiDirective = ".ascii\t";
AscizDirective = ".asciz\t";
Data8bitsDirective = ".byte\t";
Data16bitsDirective = ".short\t";
Data32bitsDirective = ".long\t";
Data64bitsDirective = ".quad\t";
SunStyleELFSectionSwitchSyntax = true; SunStyleELFSectionSwitchSyntax = true;
UsesELFSectionDirectiveForBSS = true; UsesELFSectionDirectiveForBSS = true;
//===--- Global Variable Emission Directives --------------------------===// //===--- Global Variable Emission Directives --------------------------===//
HasAggressiveSymbolFolding = true; HasAggressiveSymbolFolding = true;
COMMDirectiveAlignmentIsInBytes = false; COMMDirectiveAlignmentIsInBytes = false;
HasDotTypeDotSizeDirective = false; HasDotTypeDotSizeDirective = false;
HasNoDeadStrip = true; HasNoDeadStrip = true;
Show All 9 Lines