This is an archive of the discontinued LLVM Phabricator instance.

Differential D1467

Updated warnings in Consumed Analysis code
ClosedPublic

Authored by dblaikie on Aug 21 2013, 2:32 PM.

Details

Reviewers
chriswailes
aaron.ballman
dblaikie
delesley
Summary

A warning was added to clang that duplicated, word for world, the text from another warning. This warning was removed, and code was changed to use the existing warning.

Diff Detail

Event Timeline

eli.friedman added a comment.Aug 21 2013, 2:40 PM

LGTM.

-Eli

dblaikie commandeered this revision.Apr 5 2014, 4:21 PM
dblaikie accepted this revision.
dblaikie edited reviewers, added: chriswailes; removed: dblaikie.

Already committed in 188940

dblaikie closed this revision.Apr 5 2014, 4:22 PM

Revision Contents

PathSize
include/
clang/
Basic/
3 lines
lib/
Sema/
16 lines

Diff 3646

include/clang/Basic/DiagnosticSemaKinds.td

Context not available.
def warn_use_of_temp_while_consumed : Warning< def warn_use_of_temp_while_consumed : Warning<
"invocation of method '%0' on a temporary object while it is in the " "invocation of method '%0' on a temporary object while it is in the "
"'consumed' state">, InGroup<Consumed>, DefaultIgnore; "'consumed' state">, InGroup<Consumed>, DefaultIgnore;
def warn_uniqueness_attribute_wrong_decl_type : Warning<
"%0 attribute only applies to methods">,
InGroup<Consumed>, DefaultIgnore;
// ConsumedStrict warnings // ConsumedStrict warnings
def warn_use_in_unknown_state : Warning< def warn_use_in_unknown_state : Warning<
Context not available.

lib/Sema/SemaDeclAttr.cpp

Context not available.
if (!checkAttributeNumArgs(S, Attr, 0)) return; if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!(isa<CXXMethodDecl>(D) || isa<CXXConstructorDecl>(D))) { if (!(isa<CXXMethodDecl>(D) || isa<CXXConstructorDecl>(D))) {
S.Diag(Attr.getLoc(), diag::warn_uniqueness_attribute_wrong_decl_type) << S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) <<
Attr.getName(); Attr.getName() << ExpectedMethod;
return; return;
} }
Context not available.
if (!checkAttributeNumArgs(S, Attr, 0)) return; if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) { if (!isa<CXXMethodDecl>(D)) {
S.Diag(Attr.getLoc(), diag::warn_uniqueness_attribute_wrong_decl_type) << S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) <<
Attr.getName(); Attr.getName() << ExpectedMethod;
return; return;
} }
Context not available.
if (!checkAttributeNumArgs(S, Attr, 0)) return; if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) { if (!isa<CXXMethodDecl>(D)) {
S.Diag(Attr.getLoc(), diag::warn_uniqueness_attribute_wrong_decl_type) << S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) <<
Attr.getName(); Attr.getName() << ExpectedMethod;
return; return;
} }
Context not available.
if (!checkAttributeNumArgs(S, Attr, 0)) return; if (!checkAttributeNumArgs(S, Attr, 0)) return;
if (!isa<CXXMethodDecl>(D)) { if (!isa<CXXMethodDecl>(D)) {
S.Diag(Attr.getLoc(), diag::warn_uniqueness_attribute_wrong_decl_type) << S.Diag(Attr.getLoc(), diag::warn_attribute_wrong_decl_type) <<
Attr.getName(); Attr.getName() << ExpectedMethod;
return; return;
} }
Context not available.