This is an archive of the discontinued LLVM Phabricator instance.

Support: Recognize Borland DWARF extensions.
ClosedPublic

Authored by dawn on Nov 9 2015, 4:46 PM.

Details

Summary

This patch adds DWARF values for the Borland C++ language extensions and Delphi language.

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 39770.Nov 9 2015, 4:46 PM
dawn retitled this revision from to Support: Recognize Borland DWARF extensions..
dawn updated this object.
dawn added reviewers: dexonsmith, brucem.
dawn set the repository for this revision to rL LLVM.
dawn added a subscriber: llvm-commits.
majnemer added inline comments.
include/llvm/Support/Dwarf.h
257–274

Please keep this in numeric order.

dawn updated this revision to Diff 39781.Nov 9 2015, 8:06 PM
dawn removed rL LLVM as the repository for this revision.
dawn marked an inline comment as done.
dawn added a comment.Nov 11 2015, 9:55 AM

ping? Please accept - patches to lldb are waiting on this. Thanks.

dblaikie accepted this revision.Nov 11 2015, 9:59 AM
dblaikie added a reviewer: dblaikie.
dblaikie added a subscriber: dblaikie.

Seems OK - if there's any reference documentation you can point to for these attributes please include a reference in the code and/or the commit message.

(& don't ask me what we do when we have multiple vendor extensions with the same values... that'll be fun)

This revision is now accepted and ready to land.Nov 11 2015, 9:59 AM
dawn added a comment.Nov 11 2015, 10:29 AM

Seems OK - if there's any reference documentation you can point to for these attributes please include a reference in the code and/or the commit message.

Can you suggest a place to publish them?

(& don't ask me what we do when we have multiple vendor extensions with the same values... that'll be fun)

That's partly why I wanted to get these published, before anyone else could take these values :)

This revision was automatically updated to reflect the committed changes.