This is an archive of the discontinued LLVM Phabricator instance.

Windows-specific test for sys::path::remove_dots.
ClosedPublic

Authored by aizatsky on Nov 9 2015, 11:35 AM.

Download Raw Diff

Details

Reviewers

kcc
silvas

Commits

rGf8cf713343a0: Windows-specific test for sys::path::remove_dots.
rL252504: Windows-specific test for sys::path::remove_dots.

Diff Detail

Repository: rL LLVM

Event Timeline

aizatsky updated this revision to Diff 39727.Nov 9 2015, 11:35 AM

aizatsky retitled this revision from to Windows-specific test for sys::path::remove_dots..

aizatsky updated this object.

aizatsky added reviewers: kcc, silvas.Nov 9 2015, 11:36 AM

aizatsky added a subscriber: llvm-commits.

LGTM

This revision is now accepted and ready to land.Nov 9 2015, 11:38 AM

Closed by commit rL252504: Windows-specific test for sys::path::remove_dots. (authored by aizatsky). · Explain WhyNov 9 2015, 11:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

unittests/

Support/

Path.cpp

13 lines

Diff 39728

llvm/trunk/unittests/Support/Path.cpp

	Show First 20 Lines • Show All 847 Lines • ▼ Show 20 Lines
	static std::string remove_dots(StringRef path,			static std::string remove_dots(StringRef path,
	bool remove_dot_dot) {			bool remove_dot_dot) {
	SmallString<256> buffer(path);			SmallString<256> buffer(path);
	path::remove_dots(buffer, remove_dot_dot);			path::remove_dots(buffer, remove_dot_dot);
	return buffer.str();			return buffer.str();
	}			}

	TEST(Support, RemoveDots) {			TEST(Support, RemoveDots) {
				#if defined(LLVM_ON_WIN32)
				EXPECT_EQ("foolz\\wat", remove_dots(".\\.\\\\foolz\\wat", false));
				EXPECT_EQ("", remove_dots(".\\\\\\\\\\", false));

				EXPECT_EQ("a\\..\\b\\c", remove_dots(".\\a\\..\\b\\c", false));
				EXPECT_EQ("b\\c", remove_dots(".\\a\\..\\b\\c", true));
				EXPECT_EQ("c", remove_dots(".\\.\\c", true));

				SmallString<64> Path1(".\\.\\c");
				EXPECT_TRUE(path::remove_dots(Path1, true));
				EXPECT_EQ("c", Path1);
				#else
	EXPECT_EQ("foolz/wat", remove_dots("././/foolz/wat", false));			EXPECT_EQ("foolz/wat", remove_dots("././/foolz/wat", false));
	EXPECT_EQ("", remove_dots("./////", false));			EXPECT_EQ("", remove_dots("./////", false));

	EXPECT_EQ("a/../b/c", remove_dots("./a/../b/c", false));			EXPECT_EQ("a/../b/c", remove_dots("./a/../b/c", false));
	EXPECT_EQ("b/c", remove_dots("./a/../b/c", true));			EXPECT_EQ("b/c", remove_dots("./a/../b/c", true));
	EXPECT_EQ("c", remove_dots("././c", true));			EXPECT_EQ("c", remove_dots("././c", true));

	SmallString<64> Path1("././c");			SmallString<64> Path1("././c");
	EXPECT_TRUE(path::remove_dots(Path1, true));			EXPECT_TRUE(path::remove_dots(Path1, true));
	EXPECT_EQ("c", Path1);			EXPECT_EQ("c", Path1);
				#endif
	}			}
	} // anonymous namespace			} // anonymous namespace