This is an archive of the discontinued LLVM Phabricator instance.

Differential D14499

Inliner: Do zero-cost inlines even if above a negative threshold (PR24851)
ClosedPublic

Authored by hans on Nov 9 2015, 7:49 AM.

Details

Reviewers
eraman
Commits
rG21ce8ecb09ae: Inliner: Do zero-cost inlines even if above a negative threshold (PR24851)
rL252595: Inliner: Do zero-cost inlines even if above a negative threshold (PR24851)
Summary

Please take a look.

(See discussion at http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151102/310160.html)

Diff Detail

Repository
rL LLVM

Event Timeline

hans updated this revision to Diff 39692.Nov 9 2015, 7:49 AM
hans retitled this revision from to Inliner: Do zero-cost inlines even if above a negative threshold (PR24851).
hans updated this object.
hans added a reviewer: eraman.
hans added subscribers: llvm-commits, hansw.
jevinskie added a subscriber: jevinskie.Nov 9 2015, 9:39 AM
eraman accepted this revision.Nov 9 2015, 9:46 AM
eraman edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 9 2015, 9:46 AM
Closed by commit rL252595: Inliner: Do zero-cost inlines even if above a negative threshold (PR24851) (authored by hans). · Explain WhyNov 10 2015, 1:50 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Analysis/
2 lines
test/
Transforms/
Inline/
17 lines

Diff 39795

llvm/trunk/lib/Analysis/InlineCost.cpp

Show First 20 Lines • Show All 1,290 Lines • ▼ Show 20 Linesbool CallAnalyzer::analyzeCall(CallSite CS) {
// We applied the maximum possible vector bonus at the beginning. Now, // We applied the maximum possible vector bonus at the beginning. Now,
// subtract the excess bonus, if any, from the Threshold before // subtract the excess bonus, if any, from the Threshold before
// comparing against Cost. // comparing against Cost.
if (NumVectorInstructions <= NumInstructions / 10) if (NumVectorInstructions <= NumInstructions / 10)
Threshold -= FiftyPercentVectorBonus; Threshold -= FiftyPercentVectorBonus;
else if (NumVectorInstructions <= NumInstructions / 2) else if (NumVectorInstructions <= NumInstructions / 2)
Threshold -= (FiftyPercentVectorBonus - TenPercentVectorBonus); Threshold -= (FiftyPercentVectorBonus - TenPercentVectorBonus);
return Cost < Threshold; return Cost <= std::max(0, Threshold);
} }
#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP) #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
/// \brief Dump stats about this call's analysis. /// \brief Dump stats about this call's analysis.
void CallAnalyzer::dump() { void CallAnalyzer::dump() {
#define DEBUG_PRINT_STAT(x) dbgs() << " " #x ": " << x << "\n" #define DEBUG_PRINT_STAT(x) dbgs() << " " #x ": " << x << "\n"
DEBUG_PRINT_STAT(NumConstantArgs); DEBUG_PRINT_STAT(NumConstantArgs);
DEBUG_PRINT_STAT(NumConstantOffsetPtrArgs); DEBUG_PRINT_STAT(NumConstantOffsetPtrArgs);
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines

llvm/trunk/test/Transforms/Inline/zero-cost.ll

; RUN: opt -inline -S %s | FileCheck %s
define void @f() {
entry:
tail call void @g()
unreachable
; CHECK-LABEL: @f
; CHECK-NOT: call
; CHECK: unreachable
}
define void @g() {
entry:
unreachable
}