[ValueTracking] Teach isImpliedCondition a new bitwise trick

[sanjoy]

Summary

This change teaches isImpliedCondition to prove things like

(A | 15) < L  ==>  (A | 14) < L

if the low 4 bits of A are known to be zero.

Depends on D14391

[reames]

lib/Analysis/ValueTracking.cpp

4123 ↗

(On Diff #39407)

A cleaner way of framing this content is simply to state that X | C where X low bits are zero is equivalent to X+C.

4136 ↗

(On Diff #39407)

Hm, might it be cleaner to introduce a matcher which matches both adds and adds implemented via OR? Doing so would simplify this code, but might involve recomputing known bits twice. Not sure if this is actually a good idea or not.

4143 ↗

(On Diff #39407)

This is equivalent to 1 << LowZeroes right?

Might be clearer as uge(MaskOfOnesForLowZeros).

[sanjoy]

• address review

[reames]

LGTM w/fix for issues in comment and test which would have caught same.

lib/Analysis/ValueTracking.cpp

4128 ↗

(On Diff #39720)

match(B? You have A repeated twice.

[sanjoy]

lib/Analysis/ValueTracking.cpp

4128 ↗

(On Diff #39720)

Thanks for catching that!

When re-reading the code, I noticed something else -- the ULT and UGT clauses in isTruePredicate are unused / untested, since we only ever call it with ULE and UGE. Given that, I'm inclined to remove the the unused / untested clauses (in a separate change) -- what do you think?

[sanjoy]

lib/Analysis/ValueTracking.cpp

4128 ↗

(On Diff #39720)

I removed the untested cases in r252676.

llvm/trunk/lib/Analysis/ValueTracking.cpp

case CmpInst::ICMP_ULE: {
 
     // LHS u<  LHS +_{nuw} C   if C != 0
     // LHS u<= LHS +_{nuw} C
     if (match(RHS, m_NUWAdd(m_Specific(LHS), m_APInt(C)))) {
       if (Pred == CmpInst::ICMP_ULT)
         return C->isMinValue();
       return true;
     }
+
+    // Match A to (X +_{nuw} CA) and B to (X +_{nuw} CB)
+    auto MatchNUWAddsToSameValue = [&](Value *A, Value *B, Value *&X,
+                                       const APInt *&CA, const APInt *&CB) {
+      if (match(A, m_NUWAdd(m_Value(X), m_APInt(CA))) &&
+          match(B, m_NUWAdd(m_Specific(X), m_APInt(CB))))
+        return true;
+
+      // If X & C == 0 then (X | C) == X +_{nuw} C
+      if (match(A, m_Or(m_Value(X), m_APInt(CA))) &&
+          match(B, m_Or(m_Specific(X), m_APInt(CB)))) {
+        unsigned BitWidth = CA->getBitWidth();
+        APInt KnownZero(BitWidth, 0), KnownOne(BitWidth, 0);
+        computeKnownBits(X, KnownZero, KnownOne, DL, Depth + 1, AC, CxtI, DT);
+
+        if ((KnownZero & *CA) == *CA && (KnownZero & *CB) == *CB)
+          return true;
+      }
+
+      return false;
+    };
+
+    Value *X;
+    const APInt *CLHS, *CRHS;
+    if (MatchNUWAddsToSameValue(LHS, RHS, X, CLHS, CRHS)) {
+      if (Pred == CmpInst::ICMP_ULE)
+        return CLHS->ule(*CRHS);
+      return CLHS->ult(*CRHS);
+    }
+
     return false;
   }
   }
 }
 
 /// Return true if "icmp Pred BLHS BRHS" is true whenever "icmp Pred
 /// ALHS ARHS" is true.
 static bool isImpliedCondOperands(CmpInst::Predicate Pred, Value *ALHS,

llvm/trunk/test/Transforms/InstSimplify/implies.ll

 ; CHECK: ret i1 true
   %iplus1 = add nuw i32 %i, -100
   %var29 = icmp ult i32 %i, %length.i
   %var30 = icmp ult i32 %iplus1, %length.i
   %res = icmp ule i1 %var30, %var29
   ret i1 %res
 }
 
+define i1 @test10(i32 %length.i, i32 %x.full) {
+; CHECK-LABEL: @test10(
+; CHECK:  ret i1 true
+
+  %x = and i32 %x.full, 4294901760  ;; 4294901760 == 0xffff0000
+  %large = or i32 %x, 100
+  %small = or i32 %x, 90
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
+define i1 @test11(i32 %length.i, i32 %x) {
+; CHECK-LABEL: @test11(
+; CHECK: %res = icmp ule i1 %known, %to.prove
+; CHECK: ret i1 %res
+
+  %large = or i32 %x, 100
+  %small = or i32 %x, 90
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
+define i1 @test12(i32 %length.i, i32 %x.full) {
+; CHECK-LABEL: @test12(
+; CHECK: %res = icmp ule i1 %known, %to.prove
+; CHECK: ret i1 %res
+
+  %x = and i32 %x.full, 4294901760  ;; 4294901760 == 0xffff0000
+  %large = or i32 %x, 65536 ;; 65536 == 0x00010000
+  %small = or i32 %x, 90
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
+define i1 @test13(i32 %length.i, i32 %x) {
+; CHECK-LABEL: @test13(
+; CHECK:  ret i1 true
+
+  %large = add nuw i32 %x, 100
+  %small = add nuw i32 %x, 90
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
+define i1 @test14(i32 %length.i, i32 %x.full) {
+; CHECK-LABEL: @test14(
+; CHECK:  ret i1 true
+
+  %x = and i32 %x.full, 4294905615  ;; 4294905615 == 0xffff0f0f
+  %large = or i32 %x, 8224 ;; == 0x2020
+  %small = or i32 %x, 4112 ;; == 0x1010
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
+define i1 @test15(i32 %length.i, i32 %x) {
+; CHECK-LABEL: @test15(
+; CHECK:  %res = icmp ule i1 %known, %to.prove
+; CHECK:  ret i1 %res
+
+  %large = add nuw i32 %x, 100
+  %small = add nuw i32 %x, 110
+  %known = icmp ult i32 %large, %length.i
+  %to.prove = icmp ult i32 %small, %length.i
+  %res = icmp ule i1 %known, %to.prove
+  ret i1 %res
+}
+
 ; X >=(s) Y == X ==> Y (i1 1 becomes -1 for reasoning)
 define i1 @test_sge(i32 %length.i, i32 %i) {
 ; CHECK-LABEL: @test_sge
 ; CHECK: ret i1 true
   %iplus1 = add nsw nuw i32 %i, 1
   %var29 = icmp ult i32 %i, %length.i
   %var30 = icmp ult i32 %iplus1, %length.i
   %res = icmp sge i1 %var30, %var29
   ret i1 %res
 }