This is an archive of the discontinued LLVM Phabricator instance.

Improve OMPT initialization code
ClosedPublic

Authored by jmellorcrummey on Nov 4 2015, 3:52 PM.

Details

Summary

Use of #ifdef OMPT_DEBUG was causing messages to be generated under normal operation when the OpenMP library was compiled with KMP_DEBUG enabled. Elsewhere, KMP_DEBUG evaluates assertions, but never produces messages during normal operation. To avoid this inconsistency, set OMPT_DEBUG using a cmake variable LIBOMP_OMPT_DEBUG.

While I was editing the associated ompt-specific.h and ompt-general.c files, make the spacing and comments consistent.

Diff Detail

Event Timeline

jmellorcrummey retitled this revision from to Improve OMPT initialization code.
jmellorcrummey updated this object.
jmellorcrummey added a reviewer: jlpeyton.
jlpeyton accepted this revision.Nov 5 2015, 8:54 AM
jlpeyton edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Nov 5 2015, 8:54 AM
This revision was automatically updated to reflect the committed changes.