This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Support wasm select operator
ClosedPublic

Authored by dschuff on Nov 3 2015, 10:55 AM.

Details

Summary

Add support for wasm's select operator, and lower LLVM's select DAG node
to it.

Diff Detail

Event Timeline

dschuff updated this revision to Diff 39089.Nov 3 2015, 10:55 AM
dschuff retitled this revision from to [WebAssembly] Support wasm select operator.
dschuff updated this object.
dschuff added a reviewer: sunfish.
dschuff added subscribers: jfb, llvm-commits.
dschuff updated this revision to Diff 39092.Nov 3 2015, 10:57 AM
  • Align whitespace
sunfish accepted this revision.Nov 3 2015, 2:22 PM
sunfish edited edge metadata.

lgtm, with just one minor nit.

test/CodeGen/WebAssembly/select.ll
10

As a minor nit, we only use a single semicolon for CHECK comments in LLVM IR in the other tests.

This revision is now accepted and ready to land.Nov 3 2015, 2:22 PM
dschuff updated this revision to Diff 39122.Nov 3 2015, 2:39 PM
dschuff edited edge metadata.
  • Address nit
test/CodeGen/WebAssembly/select.ll
10

oops, too many .wast tests in my head.
Done.

This revision was automatically updated to reflect the committed changes.