This is an archive of the discontinued LLVM Phabricator instance.

Unbreak build on OpenBSD
ClosedPublic

Authored by sisnkemp on Nov 2 2015, 7:45 AM.

Download Raw Diff

Details

Reviewers

• rafael
yaron.keren

Summary

This is similar to the fix for FreeBSD in r226862. Without this patch, the build aborts when linkling libLTO.so, complaining about undefined references to assert2, cxa_atexit, etc.

Diff Detail

Event Timeline

sisnkemp updated this revision to Diff 38924.Nov 2 2015, 7:45 AM

sisnkemp retitled this revision from to Unbreak build on OpenBSD.

sisnkemp updated this object.

sisnkemp added a subscriber: llvm-commits.

LGTM.

Ping. If it is ok, can somebody please commit this? Thanks.

sisnkemp updated this revision to Diff 40229.Nov 15 2015, 1:15 AM

sisnkemp added reviewers: • rafael, yaron.keren.Nov 20 2015, 10:30 AM

r253769

This revision is now accepted and ready to land.Nov 20 2015, 10:47 PM

yaron.keren closed this revision.Nov 20 2015, 10:47 PM

Revision Contents

Path

Size

cmake/

modules/

HandleLLVMOptions.cmake

3 lines

Diff 40229

cmake/modules/HandleLLVMOptions.cmake

	Show First 20 Lines • Show All 126 Lines • ▼ Show 20 Lines
	if(APPLE)			if(APPLE)
	# Darwin-specific linker flags for loadable modules.			# Darwin-specific linker flags for loadable modules.
	set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress")			set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} -Wl,-flat_namespace -Wl,-undefined -Wl,suppress")
	endif()			endif()

	# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO			# Pass -Wl,-z,defs. This makes sure all symbols are defined. Otherwise a DSO
	# build might work on ELF but fail on MachO/COFF.			# build might work on ELF but fail on MachO/COFF.
	if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR			if(NOT (${CMAKE_SYSTEM_NAME} MATCHES "Darwin" OR WIN32 OR CYGWIN OR
	${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD") AND			${CMAKE_SYSTEM_NAME} MATCHES "FreeBSD" OR
				${CMAKE_SYSTEM_NAME} MATCHES "OpenBSD") AND
	NOT LLVM_USE_SANITIZER)			NOT LLVM_USE_SANITIZER)
	set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")			set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-z,defs")
	endif()			endif()


	function(append value)			function(append value)
	foreach(variable ${ARGN})			foreach(variable ${ARGN})
	set(${variable} "${${variable}} ${value}" PARENT_SCOPE)			set(${variable} "${${variable}} ${value}" PARENT_SCOPE)
	▲ Show 20 Lines • Show All 454 Lines • Show Last 20 Lines