This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Fix build errors for TSan on OS X
ClosedPublic

Authored by kubamracek on Nov 2 2015, 7:40 AM.

Details

Summary

This patch moves a few functions from sanitizer_linux_libcdep.cc to sanitizer_posix_libcdep.cc in order to use them on OS X as well. Plus a few more small build fixes.

This is part of an effort to port TSan to OS X, and it's one the very first steps. Don't expect TSan on OS X to actually work or pass tests at this point.

Diff Detail

Event Timeline

kubamracek updated this revision to Diff 38921.Nov 2 2015, 7:40 AM
kubamracek retitled this revision from to [tsan] Fix build errors for TSan on OS X.
kubamracek updated this object.
kubamracek added reviewers: samsonov, glider, dvyukov, kcc.
dvyukov accepted this revision.Nov 3 2015, 3:12 AM
dvyukov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 3 2015, 3:12 AM
kubamracek updated this revision to Diff 39049.Nov 3 2015, 5:37 AM
kubamracek edited edge metadata.

Updating diff so it actually compiles on Linux. I needed to put my_pthread_attr_getstack in a header file, is that okay?

I needed to put my_pthread_attr_getstack in a header file, is that okay?

Looks fine to me

This revision was automatically updated to reflect the committed changes.

Thanks for the reviews!