This is an archive of the discontinued LLVM Phabricator instance.

Fix test check label.
ClosedPublic

Authored by tejohnson on Oct 29 2015, 6:15 AM.

Details

Summary

I noticed when manually modifying this test that it was passing when I
expected it to fail. Looks like the combination of LABEL and NOT on the
check does not work. This can also be seen when running FileCheck with
only that one -check-prefix (removing the additional -check-prefix=B):

/usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/llvm-link -S -internalize -only-needed /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.b.bc /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.c.bc | /usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/FileCheck /usr/local/google/home/tejohnson/llvm/llvm_11/test/Linker/link-flags.ll -check-prefix=CN
error: no check strings found with prefix 'CN:'

The CN prefix checks don't in fact need "LABEL" so remove that.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson updated this revision to Diff 38726.Oct 29 2015, 6:15 AM
tejohnson retitled this revision from to Fix test check label..
tejohnson updated this object.
tejohnson added a reviewer: tra.
tejohnson added a subscriber: llvm-commits.
tra accepted this revision.Oct 29 2015, 10:04 AM
tra edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 29 2015, 10:04 AM
This revision was automatically updated to reflect the committed changes.