Page MenuHomePhabricator

Address another race condition running tests on Windows
AbandonedPublic

Authored by amccarth on Oct 28 2015, 3:32 PM.

Details

Reviewers
zturner
Summary

Another case where sleep-and-retry avoids file access errors on Windows.

Diff Detail

Event Timeline

amccarth updated this revision to Diff 38693.Oct 28 2015, 3:32 PM
amccarth retitled this revision from to Address another race condition running tests on Windows.
amccarth updated this object.
amccarth added a reviewer: zturner.
amccarth added a subscriber: lldb-commits.
zturner added inline comments.Oct 28 2015, 3:42 PM
packages/Python/lldbsuite/test/lldbtest.py
1823–1830

I have a patch pending to create an lldbsuite.support package. I wonder if it would be worth sinking this "rename with retry" (and similar for delete-with-retry) into this library. Then you could call this as:

lldbsuite.support.filesystem.rename_with_retry(src, dst, 1)  # Retry up to 1 time

I only mention this because this is now the second time we've had to do this (other time right below), so perhaps we might need this again in the future too.

I don't feel too strongly, so up to you. If you think it's a good idea though, you'll probably need to wait until my CL goes in first so that you can add this method to the package (which doesn't exist yet)

amccarth added inline comments.Oct 28 2015, 3:57 PM
packages/Python/lldbsuite/test/lldbtest.py
1823–1830

I'm happy to wait. I just glad I found the root cause.

zturner edited edge metadata.Nov 6 2015, 10:23 AM

Feel free to get this in. Maybe put it in file lldbsuite/support/filesystem.py

I'm not seeing this problem now that many of the other changes are in. I'm going to hold off until I see it again.

amccarth abandoned this revision.Mar 28 2016, 10:45 AM