This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Update opcode name format for conversions
ClosedPublic

Authored by s3ththompson on Oct 28 2015, 3:00 PM.

Details

Summary

Conversion opcode name format should be f64.convert_u/i64 not f64_convert_u

Diff Detail

Event Timeline

s3ththompson retitled this revision from to [WebAssembly] Update opcode name format for conversions.
s3ththompson updated this object.
s3ththompson added a reviewer: jfb.
s3ththompson added a subscriber: llvm-commits.
jfb edited edge metadata.Oct 28 2015, 8:30 PM

One small typo, then this lgtm. I'll land the patch fro you once you update the comment.

lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp
99–100

"with their in type"

s3ththompson edited edge metadata.

Clarification of comment

s3ththompson marked an inline comment as done.Oct 28 2015, 8:46 PM

Fixed typo

This revision was automatically updated to reflect the committed changes.