This is an archive of the discontinued LLVM Phabricator instance.

[mips][microMIPS] Implement SUBQ[_S].PH, SUBQ_S.W, SUBQH[_R].PH, SUBQH[_R].W, SUBU[_S].PH, SUBU[_S].QB and SUBUH[_R].QB instructions
ClosedPublic

Authored by zbuljan on Oct 27 2015, 6:22 AM.

Details

Summary

The patch implements microMIPSDSP instructions: SUBQ[_S].PH, SUBQ_S.W, SUBQH[_R].PH, SUBQH[_R].W, SUBU[_S].PH, SUBU[_S].QB and SUBUH[_R].QB

Diff Detail

Repository
rL LLVM

Event Timeline

zbuljan updated this revision to Diff 38535.Oct 27 2015, 6:22 AM
zbuljan retitled this revision from to [mips][microMIPS] Implement SUBQ[_S].PH, SUBQ_S.W, SUBQH[_R].PH, SUBQH[_R].W, SUBU[_S].PH, SUBU[_S].QB and SUBUH[_R].QB instructions.
zbuljan updated this object.
zbuljan added subscribers: petarj, llvm-commits.
dsanders accepted this revision.Nov 14 2015, 5:55 AM
dsanders edited edge metadata.

LGTM with a small test change.

test/MC/Disassembler/Mips/micromips-dspr2/valid.txt
18–25 ↗(On Diff #38535)

The DSPr1 tests should also be present. Likewise for the assembler tests.

See my comment on D14058 for more info.

This revision is now accepted and ready to land.Nov 14 2015, 5:55 AM
This revision was automatically updated to reflect the committed changes.