Page MenuHomePhabricator

[ValueTracking] Use !range metadata more aggressively in KnownBits
ClosedPublic

Authored by sanjoy on Oct 26 2015, 6:46 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

sanjoy updated this revision to Diff 38489.Oct 26 2015, 6:46 PM
sanjoy retitled this revision from to [ValueTracking] Compute sign bit from range metadata.
sanjoy updated this object.
sanjoy added reviewers: jingyue, majnemer, nlewycky.
sanjoy added a subscriber: llvm-commits.
jingyue accepted this revision.Oct 26 2015, 6:59 PM
jingyue edited edge metadata.
jingyue added inline comments.
test/Analysis/ValueTracking/sign-bit-from-md.ll
10 ↗(On Diff #38489)

ret i1 true

I'd be slightly more verbose to filter out unwanted cases such as and i8 true, ....

This revision is now accepted and ready to land.Oct 26 2015, 6:59 PM
sanjoy marked an inline comment as done.Oct 26 2015, 7:04 PM
sanjoy added inline comments.
test/Analysis/ValueTracking/sign-bit-from-md.ll
10 ↗(On Diff #38489)

Will fix and check in.

sanjoy retitled this revision from [ValueTracking] Compute sign bit from range metadata to [ValueTracking] Use !range metadata more aggressively in KnownBits.Oct 26 2015, 11:12 PM
sanjoy updated this object.
sanjoy edited edge metadata.
sanjoy updated this revision to Diff 38503.Oct 26 2015, 11:13 PM
  • address Nick's review
nlewycky accepted this revision.Oct 27 2015, 9:47 AM
nlewycky edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.