[MC] Get rid of NDEBUG in headers

[davide]

Summary

Hope this is reasonable for you, Jim.

[majnemer]

llvm/CodeGen/TargetSchedule.h

110–115 ↗

(On Diff #38350)

This shouldn't have ABI impact, should it? Why not leave it in the NDEBUG?

[davide]

You're right, my bad. New diff.

[davide]

Related to http://reviews.llvm.org/D16073 , maybe this one should use LLVM_ENABLE_ABI_BREAKING_CHECKS as well?

Thanks!

Davide

[dexonsmith]

Yes, I think we should use LLVM_ENABLE_ABI_BREAKING_CHECKS here.

llvm/MC/MCSchedule.h

 #include <cassert>
 
 namespace llvm {
 
 struct InstrItinerary;
 
 /// Define a kind of processor resource that will be modeled by the scheduler.
 struct MCProcResourceDesc {
-#ifndef NDEBUG
   const char *Name;
-#endif
   unsigned NumUnits; // Number of resource of this kind
   unsigned SuperIdx; // Index of the resources kind that contains this kind.
 
   // Number of resources that may be buffered.
   //
   // Buffered resources (BufferSize != 0) may be consumed at some indeterminate
   // cycle after dispatch. This should be used for out-of-order cpus when
   // instructions that use this resource can be buffered in a reservaton

 /// Summarize the scheduling resources required for an instruction of a
 /// particular scheduling class.
 ///
 /// Defined as an aggregate struct for creating tables with initializer lists.
 struct MCSchedClassDesc {
   static const unsigned short InvalidNumMicroOps = UINT16_MAX;
   static const unsigned short VariantNumMicroOps = UINT16_MAX - 1;
 
-#ifndef NDEBUG
-  const char* Name;
-#endif
+  const char *Name;
   unsigned short NumMicroOps;
   bool     BeginGroup;
   bool     EndGroup;
   unsigned WriteProcResIdx; // First index into WriteProcResTable.
   unsigned NumWriteProcResEntries;
   unsigned WriteLatencyIdx; // First index into WriteLatencyTable.
   unsigned NumWriteLatencyEntries;
   unsigned ReadAdvanceIdx; // First index into ReadAdvanceTable.